From 1581637a61e577d5a868c787da452e4141e86660 Mon Sep 17 00:00:00 2001 From: Benoit Girard Date: Wed, 11 Jun 2014 15:53:50 -0400 Subject: [PATCH] Bug 1024063 - Make the 'threads' feature implicit if thread filter is specific. r=ehsan --- tools/profiler/TableTicker.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/profiler/TableTicker.h b/tools/profiler/TableTicker.h index 25aa1b1ae7bc..15dde7d8382f 100644 --- a/tools/profiler/TableTicker.h +++ b/tools/profiler/TableTicker.h @@ -65,7 +65,9 @@ class TableTicker: public Sampler { mProfileJS = hasFeature(aFeatures, aFeatureCount, "js"); mProfileJava = hasFeature(aFeatures, aFeatureCount, "java"); mProfilePower = hasFeature(aFeatures, aFeatureCount, "power"); - mProfileThreads = hasFeature(aFeatures, aFeatureCount, "threads"); + // Users sometimes ask to filter by a list of threads but forget to request + // profiling non main threads. Let's make it implificit if we have a filter + mProfileThreads = hasFeature(aFeatures, aFeatureCount, "threads") || aFilterCount > 0; mUnwinderThread = hasFeature(aFeatures, aFeatureCount, "unwinder") || sps_version2(); mAddLeafAddresses = hasFeature(aFeatures, aFeatureCount, "leaf"); mPrivacyMode = hasFeature(aFeatures, aFeatureCount, "privacy");