Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-03 02:25:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1712642: allow overwrite for WriteMode::Overwrite and WriteMode::Append r=barret

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D115849
This commit is contained in:
Emma Malysz 2021-05-26 16:46:03 +00:00
parent dd9149a109
commit 16596721d7
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dom/system/IOUtils.cpp
View File

@ -932,7 +932,7 @@ Result<uint32_t, IOUtils::IOError> IOUtils::WriteSync(
nsCOMPtr<nsIFile> toMove;
MOZ_ALWAYS_SUCCEEDS(aFile->Clone(getter_AddRefs(toMove)));
bool noOverwrite = aOptions.mMode != WriteMode::Create;
bool noOverwrite = aOptions.mMode == WriteMode::Create;
if (MoveSync(toMove, backupFile, noOverwrite).isErr()) {
return Err(IOError(NS_ERROR_FILE_COPY_OR_MOVE_FAILED)

26
dom/system/tests/ioutils/test_ioutils_read_write.html
View File

@ -153,6 +153,7 @@
info("Test backup with tmp and backup file options, existing destination");
let newFileContents = new TextEncoder().encode("New file contents");
ok(await fileExists(destFileName), `Expected ${destFileName} to exist`);
bytesWritten =
await IOUtils.write(destFileName, newFileContents, {
backupFile: backupFileName,
@ -174,6 +175,31 @@
"IOUtils::write IOUtils::write can move tmp file to destination after performing a backup"
);
info("Test backup with tmp and backup file options, existing destination and backup");
newFileContents = new TextEncoder().encode("Updated new file contents");
ok(await fileExists(destFileName), `Expected ${destFileName} to exist`);
ok(await fileExists(backupFileName), `Expected ${backupFileName} to exist`);
bytesWritten =
await IOUtils.write(destFileName, newFileContents, {
backupFile: backupFileName,
tmpPath: tmpFileName,
});
ok(!await fileExists(tmpFileName), "IOUtils::write cleans up the tmpFile");
ok(
await fileHasTextContents(backupFileName, "New file contents"),
"IOUtils::write can create a backup if the target file exists"
);
ok(
await fileHasTextContents(destFileName, "Updated new file contents"),
"IOUtils::write can write to the destination when a temporary file is used"
);
is(
bytesWritten,
newFileContents.length,
"IOUtils::write IOUtils::write can move tmp file to destination after performing a backup"
);
await cleanup(destFileName, backupFileName);
});