Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 15:52:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

crash fix in Cocoa menus. we build this code in Camino but we don't use it. sr=pinkerton

Browse Source
This commit is contained in:
joshmoz%gmail.com 2005-10-26 23:25:19 +00:00
parent 11014437a0
commit 16ad0bb77c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
widget/src/cocoa/nsMenuX.mm
View File

@ -386,6 +386,7 @@ NS_IMETHODIMP nsMenuX::RemoveItem(const PRUint32 aPos)
NS_IMETHODIMP nsMenuX::RemoveAll()
{
//XXXJOSH why don't we set |mNumMenuItems| to 0 after removing all menu items?
if (mMacMenu != NULL) {
/*
// clear command id's
@ -399,9 +400,7 @@ NS_IMETHODIMP nsMenuX::RemoveAll()
}
}
*/
//XXXJOSH we crash here sometimes, log message shows
// nsMenuX::RemoveAll: Total menu count is 16, attempting to access 31
for (int i = mNumMenuItems - 1; i >= 0; i--) {
for (int i = [mMacMenu numberOfItems] - 1; i >= 0; i--) {
[mMacMenu removeItemAtIndex:i];
}
}