Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ

These are two other cases where grouping is not really necessary. For accessibility, the checkbox at the end of the download interstitial dialog does not need to be in the same group as the radio button, and the question text can more simply just label the radiogroup. The vbox is still necessary to hide the section, but is not related to accessibility or dialog structure.

Differential Revision: https://phabricator.services.mozilla.com/D8421

--HG--
extra : source : b11d646505c15a1b9ecdcf4dc21199c13ed432c2

browser/components/shell/content/setDesktopBackground.xul

@@ -61,14 +61,12 @@
                   onchange="gSetBackground.updateColor(this.value);"/> 
     </hbox>
 #endif
-    <groupbox align="center">
-      <caption label="&preview.label;"/>
-      <stack>
-        <!-- if width and height are not present, they default to 300x150 and stretch the stack -->
-        <html:canvas id="screen" width="1" height="1"/>
-        <image id="monitor"/>
-      </stack>
-    </groupbox>
+
+    <stack>
+      <!-- if width and height are not present, they default to 300x150 and stretch the stack -->
+      <html:canvas id="screen" width="1" height="1" role="presentation"/>
+      <image id="monitor"/>
+    </stack>
 
 #ifdef XP_MACOSX
     <separator/>

browser/locales/en-US/chrome/browser/setDesktopBackground.dtd

@@ -8,7 +8,6 @@
 <!ENTITY stretch.label              "Stretch">
 <!ENTITY fill.label                 "Fill">
 <!ENTITY fit.label                  "Fit">
-<!ENTITY preview.label              "Preview">
 <!ENTITY color.label                "Color:">
 <!ENTITY setDesktopBackground.title "Set Desktop Background">
 <!ENTITY openDesktopPrefs.label     "Open Desktop Preferences">

toolkit/mozapps/downloads/content/unknownContentType.xul

@@ -58,9 +58,9 @@
       <label id="unknownPrompt" value="&unknownPromptText.label;" flex="1"/>
     </hbox>
 
-    <groupbox flex="1" id="normalBox">
-      <caption label="&actionQuestion.label;"/>
-      <separator class="thin"/>
+    <vbox flex="1" id="normalBox">
+      <separator/>
+      <label control="mode" class="header" value="&actionQuestion.label;"/>
       <radiogroup id="mode" class="small-indent">
         <hbox>
           <radio id="open" label="&openWith.label;" accesskey="&openWith.accesskey;"/>
@@ -93,7 +93,7 @@
       <description id="settingsChange" hidden="true">&settingsChangeOptions.label;</description>
 #endif
       <separator class="thin"/>
-    </groupbox>
+    </vbox>
   </vbox>
   
   <menulist id="openHandler" flex="1">