bug 63368 adds a "make check" rule to the build system, which currently runs necko unit tests + the version comparator tests

r=cls,bsmedberg a=bsmedberg

config/rules.mk

@@ -1772,7 +1772,7 @@ endif
 # Fake targets.  Always run these rules, even if a file/directory with that
 # name already exists.
 #
-.PHONY: all all_platforms alltags boot checkout chrome realchrome clean clobber clobber_all export install libs makefiles realclean run_viewer run_apprunner tools $(DIRS) $(TOOL_DIRS) FORCE
+.PHONY: all all_platforms alltags boot checkout chrome realchrome clean clobber clobber_all export install libs makefiles realclean run_viewer run_apprunner tools $(DIRS) $(TOOL_DIRS) FORCE check
 
 # Used as a dependency to force targets to rebuild
 FORCE:
@@ -1899,3 +1899,7 @@ endif
 documentation:
 	@cd $(DEPTH)
 	$(DOXYGEN) $(DEPTH)/config/doxygen.cfg
+
+check:: $(SUBMAKEFILES) $(MAKE_DIRS)
+	+$(LOOP_OVER_DIRS)
+	+$(LOOP_OVER_TOOL_DIRS)

netwerk/test/Makefile.in

@@ -103,6 +103,9 @@ _UNIT_FILES	= unit/test_all.sh \
 libs:: $(_UNIT_FILES)
 	$(INSTALL) $^ $(DIST)/bin/necko_unit_tests
 
+check::
+	$(RUN_TEST_PROGRAM) $(DIST)/bin/necko_unit_tests/test_all.sh
+
 _RES_FILES 	= urlparse.dat \
 		  urlparse_unx.dat \
 		  jarlist.dat \

netwerk/test/unit/test_all.sh

@@ -44,20 +44,19 @@ ulimit -c 20480 2> /dev/null
 dir=`dirname $0`
 bin="$dir/.."
 
+exit_status=0
+
 for t in $dir/test_*.js
 do
-    if [ `uname` = "Darwin" ]; then
-        DYLD_LIBRARY_PATH=$bin
-        export DYLD_LIBRARY_PATH
-    else
-        LD_LIBRARY_PATH=$bin
-        export LD_LIBRARY_PATH
-    fi
+    echo -n "$t: "
     $bin/xpcshell -f $dir/head.js -f $t -f $dir/tail.js 2> $t.log 1>&2
     if [ `grep -c '\*\*\* PASS' $t.log` = 0 ]
     then
-        echo "$t: FAIL (see $t.log)"
+        echo "FAIL (see $t.log)"
+        exit_status=1
     else
-        echo "$t: PASS"
+        echo "PASS"
     fi
 done
+
+exit $exit_status

xpcom/tests/Makefile.in

@@ -112,8 +112,6 @@ libs::
 install::
 	$(SYSINSTALL) $(IFLAGS1) $(srcdir)/test.properties $(DESTDIR)$(mozappdir)/res
 
-ifndef CROSS_COMPILE
-libs::
+check::
 	@echo "Running TestVersionComparator tests"
 	@$(PERL) -w $(srcdir)/TestVersionComparatorRunner.pl "$(RUN_TEST_PROGRAM) $(FINAL_TARGET)/TestVersionComparator$(BIN_SUFFIX)"
-endif