Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 09:15:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Respect addProperty failure (148899, r=khanson, sr=shaver).

Browse Source
This commit is contained in:
brendan%mozilla.org 2002-06-04 18:13:55 +00:00
parent a9501b52c4
commit 1740ef44a7
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
js/src/jsobj.c
View File

@ -2084,8 +2084,10 @@ js_DefineNativeProperty(JSContext *cx, JSObject *obj, jsid id, jsval value,
goto bad;
/* XXXbe called with lock held */
if (!clasp->addProperty(cx, obj, SPROP_USERID(sprop), &value))
if (!clasp->addProperty(cx, obj, SPROP_USERID(sprop), &value)) {
(void) js_RemoveScopeProperty(cx, scope, id);
goto bad;
}
PROPERTY_CACHE_FILL(&cx->runtime->propertyCache, obj, id, sprop);
if (SPROP_HAS_VALID_SLOT(sprop, scope))
@ -2651,6 +2653,7 @@ js_SetProperty(JSContext *cx, JSObject *obj, jsid id, jsval *vp)
/* XXXbe called with obj locked */
if (!clasp->addProperty(cx, obj, SPROP_USERID(sprop), vp)) {
(void) js_RemoveScopeProperty(cx, scope, id);
JS_UNLOCK_SCOPE(cx, scope);
return JS_FALSE;
}