From 17821c9ee3b64b16feee460f81471c936fe8be13 Mon Sep 17 00:00:00 2001 From: Mike Hommey Date: Thu, 9 Jun 2016 15:27:59 +0900 Subject: [PATCH] Bug 1279151 - Version'ize the result of yasm_version. r=chmanchester Before bug 1269513, yasm_version returned a Version object, and it doesn't anymore, which made the assignment of _YASM_*_VERSION skipped silently. Then, configure would go through the yasm version checks as if they were false and skipping over the AC_MSG_ERRORs, printing out: /builds/slave/try-m64-0000000000000000000000/build/src/old-configure: line 19615: test: : integer expression expected which is why this went undetected: the version checks were simply ignored. Some shells, however, evaluated the yasm version checks as true, hitting the AC_MSG_ERRORs. --- build/moz.configure/toolchain.configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/moz.configure/toolchain.configure b/build/moz.configure/toolchain.configure index 17bddfed775f..70863d5c2ade 100644 --- a/build/moz.configure/toolchain.configure +++ b/build/moz.configure/toolchain.configure @@ -15,7 +15,7 @@ def yasm_version(yasm): yasm, '--version', onerror=lambda: die('Failed to get yasm version.') ).splitlines()[0].split()[1] - return version + return Version(version) # Until we move all the yasm consumers out of old-configure. # bug 1257904