Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-11 04:15:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 975167 - Traceback in autocompletion while debugging; r=past

Browse Source
This commit is contained in:
Mihai Sucan 2014-02-21 21:06:20 +02:00
parent 1c9d408590
commit 180e2f4d62
2 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
browser/devtools/webconsole/test/browser_webconsole_autocomplete_in_debugger_stackframe.js
View File

@ -182,7 +182,7 @@ function testCompletion(hud) {
return item.label != "prop1";
}), "autocomplete results do contain prop1");
// Test if 'foo1Obj.prop1.' gives 'prop11'
// Test if 'foo2Obj.prop1.' gives 'prop11'
input.value = "foo2Obj.prop1.";
input.setSelectionRange(14, 14);
jsterm.complete(jsterm.COMPLETE_HINT_ONLY, testNext);
@ -193,7 +193,7 @@ function testCompletion(hud) {
return item.label != "prop11";
}), "autocomplete results do contain prop11");
// Test if 'foo1Obj.prop1.prop11.' gives suggestions for a string i.e. 'length'
// Test if 'foo2Obj.prop1.prop11.' gives suggestions for a string i.e. 'length'
input.value = "foo2Obj.prop1.prop11.";
input.setSelectionRange(21, 21);
jsterm.complete(jsterm.COMPLETE_HINT_ONLY, testNext);
@ -204,6 +204,15 @@ function testCompletion(hud) {
return item.label != "length";
}), "autocomplete results do contain length");
// Test if 'foo1Obj[0].' throws no errors.
input.value = "foo2Obj[0].";
input.setSelectionRange(11, 11);
jsterm.complete(jsterm.COMPLETE_HINT_ONLY, testNext);
yield undefined;
newItems = popup.getItems();
is(newItems.length, 0, "no items for foo2Obj[0]");
testDriver = null;
executeSoon(finishTest);
yield undefined;

7
toolkit/devtools/webconsole/utils.js
View File

@ -1043,7 +1043,12 @@ let DebuggerEnvironmentSupport = {
getProperty: function(aObj, aName)
{
// TODO: we should use getVariableDescriptor() here - bug 725815.
let result = aObj.getVariable(aName);
let result = undefined;
try {
result = aObj.getVariable(aName);
} catch (ex) {
// getVariable() throws for invalid identifiers.
}
return result === undefined ? null : { value: result };
},
};