Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1748146 - Return early in AbortSignal::SignalAbort r=smaug

Browse Source 
Currently only AbortSignalImpl::SignalAbort returns early. Both can be called directly, so both should return early.

Currently not really testable since this is only problematic in dom/streams and it's still hidden by a build flag.

Differential Revision: https://phabricator.services.mozilla.com/D135278
This commit is contained in:
Kagami Sascha Rosylight 2022-01-07 17:52:40 +00:00
parent bb0b1417c3
commit 182baf5159
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dom/abort/AbortSignal.cpp
View File

@ -152,6 +152,11 @@ void AbortSignal::ThrowIfAborted(JSContext* aCx, ErrorResult& aRv) {
// https://dom.spec.whatwg.org/#abortsignal-signal-abort
void AbortSignal::SignalAbort(JS::Handle<JS::Value> aReason) {
// Step 1, in case "signal abort" algorithm is called directly
if (Aborted()) {
return;
}
// Steps 1-4.
AbortSignalImpl::SignalAbort(aReason);