Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-01 05:48:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 736898: Avoid signed/unsigned comparisons in tools/profiler, r=bgirard

Browse Source 
--HG--
extra : rebase_source : 53eadd48e29fc1aae143b0480bcb573a392e1130
This commit is contained in:
Brian Smith 2012-04-04 18:56:25 -07:00
parent c948018118
commit 1894f363b5
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/profiler/TableTicker.cpp
View File

@ -580,7 +580,7 @@ void doSampleStackTrace(ProfileStack *aStack, ThreadProfile &aProfile, TickSampl
// Sample
// 's' tag denotes the start of a sample block
// followed by 0 or more 'c' tags.
for (int i = 0; i < aStack->mStackPointer; i++) {
for (mozilla::sig_safe_t i = 0; i < aStack->mStackPointer; i++) {
if (i == 0) {
Address pc = 0;
if (sample) {

3
tools/profiler/sps_sampler.h
View File

@ -212,7 +212,8 @@ public:
if (mQueueClearMarker) {
clearMarkers();
}
if (aMarkerId >= mMarkerPointer) {
if (aMarkerId < 0 ||
static_cast<mozilla::sig_safe_t>(aMarkerId) >= mMarkerPointer) {
return NULL;
}
return mMarkers[aMarkerId];