From 18e758c3ca71510c2b643054180702b41a333c47 Mon Sep 17 00:00:00 2001 From: "hyatt%netscape.com" Date: Tue, 5 Sep 2000 22:52:57 +0000 Subject: [PATCH] fix for 51410 - xbl syntax change, r=danm --- content/xbl/src/nsXBLBinding.cpp | 10 +++++++--- layout/xbl/src/nsXBLBinding.cpp | 10 +++++++--- .../resources/content/mailComposeBindings.xml | 2 +- themes/blue/communicator/menubuttonBindings.xml | 4 ++-- themes/classic/communicator/menubuttonBindings.xml | 2 +- themes/classic/global/mac/classicBindings.xml | 4 ++-- themes/classic/global/menubuttonBindings.xml | 2 +- themes/classic/global/win/classicBindings.xml | 12 ++++++------ themes/modern/communicator/menubuttonBindings.xml | 4 ++-- themes/modern/global/globalBindings.xml | 6 +++--- .../resources/content/dialogBindings.xml | 6 +++--- .../console/resources/content/consoleBindings.xml | 12 ++++++------ xpfe/global/resources/content/dialogBindings.xml | 6 +++--- xpfe/global/resources/content/menulistBindings.xml | 10 +++++----- xpfe/global/resources/content/toolbarBindings.xml | 6 +++--- xpfe/global/resources/content/xulBindings.xml | 6 +++--- 16 files changed, 55 insertions(+), 47 deletions(-) diff --git a/content/xbl/src/nsXBLBinding.cpp b/content/xbl/src/nsXBLBinding.cpp index 9810789b15b3..33d6e3f3a921 100644 --- a/content/xbl/src/nsXBLBinding.cpp +++ b/content/xbl/src/nsXBLBinding.cpp @@ -1538,15 +1538,15 @@ nsXBLBinding::ConstructAttributeTable(nsIContent* aElement) // Figure out if this token contains a :. nsAutoString attrTok; attrTok.AssignWithConversion(token); - PRInt32 index = attrTok.Find(":", PR_TRUE); + PRInt32 index = attrTok.Find("=", PR_TRUE); if (index != -1) { // This attribute maps to something different. nsAutoString left, right; attrTok.Left(left, index); attrTok.Right(right, attrTok.Length()-index-1); - atom = getter_AddRefs(NS_NewAtom(left.GetUnicode())); - attribute = getter_AddRefs(NS_NewAtom(right.GetUnicode())); + atom = getter_AddRefs(NS_NewAtom(right.GetUnicode())); + attribute = getter_AddRefs(NS_NewAtom(left.GetUnicode())); } else { nsAutoString tok; tok.AssignWithConversion(token); @@ -1600,6 +1600,10 @@ nsXBLBinding::ConstructAttributeTable(nsIContent* aElement) } } + // Now remove the inherits attribute from the cloned element. It is used + // on the template only, and we don't need it anymore. + aElement->UnsetAttribute(kNameSpaceID_None, kInheritsAtom, PR_FALSE); + token = nsCRT::strtok( newStr, ", ", &newStr ); } diff --git a/layout/xbl/src/nsXBLBinding.cpp b/layout/xbl/src/nsXBLBinding.cpp index 9810789b15b3..33d6e3f3a921 100644 --- a/layout/xbl/src/nsXBLBinding.cpp +++ b/layout/xbl/src/nsXBLBinding.cpp @@ -1538,15 +1538,15 @@ nsXBLBinding::ConstructAttributeTable(nsIContent* aElement) // Figure out if this token contains a :. nsAutoString attrTok; attrTok.AssignWithConversion(token); - PRInt32 index = attrTok.Find(":", PR_TRUE); + PRInt32 index = attrTok.Find("=", PR_TRUE); if (index != -1) { // This attribute maps to something different. nsAutoString left, right; attrTok.Left(left, index); attrTok.Right(right, attrTok.Length()-index-1); - atom = getter_AddRefs(NS_NewAtom(left.GetUnicode())); - attribute = getter_AddRefs(NS_NewAtom(right.GetUnicode())); + atom = getter_AddRefs(NS_NewAtom(right.GetUnicode())); + attribute = getter_AddRefs(NS_NewAtom(left.GetUnicode())); } else { nsAutoString tok; tok.AssignWithConversion(token); @@ -1600,6 +1600,10 @@ nsXBLBinding::ConstructAttributeTable(nsIContent* aElement) } } + // Now remove the inherits attribute from the cloned element. It is used + // on the template only, and we don't need it anymore. + aElement->UnsetAttribute(kNameSpaceID_None, kInheritsAtom, PR_FALSE); + token = nsCRT::strtok( newStr, ", ", &newStr ); } diff --git a/mailnews/compose/resources/content/mailComposeBindings.xml b/mailnews/compose/resources/content/mailComposeBindings.xml index 3c8aac94e3e9..4077b368e1d0 100644 --- a/mailnews/compose/resources/content/mailComposeBindings.xml +++ b/mailnews/compose/resources/content/mailComposeBindings.xml @@ -10,7 +10,7 @@ extends="chrome://global/content/xulBindings.xml#menuitem"> - diff --git a/themes/blue/communicator/menubuttonBindings.xml b/themes/blue/communicator/menubuttonBindings.xml index 959f814b59db..53485099fed7 100644 --- a/themes/blue/communicator/menubuttonBindings.xml +++ b/themes/blue/communicator/menubuttonBindings.xml @@ -9,7 +9,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey,disabled"/> @@ -21,7 +21,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey,disabled"/> diff --git a/themes/classic/communicator/menubuttonBindings.xml b/themes/classic/communicator/menubuttonBindings.xml index 32d407d11b28..f70691ce8289 100644 --- a/themes/classic/communicator/menubuttonBindings.xml +++ b/themes/classic/communicator/menubuttonBindings.xml @@ -8,7 +8,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey,disabled"/> diff --git a/themes/classic/global/mac/classicBindings.xml b/themes/classic/global/mac/classicBindings.xml index ba1bb1d71c96..9390615e7969 100644 --- a/themes/classic/global/mac/classicBindings.xml +++ b/themes/classic/global/mac/classicBindings.xml @@ -80,13 +80,13 @@ - + - + diff --git a/themes/classic/global/menubuttonBindings.xml b/themes/classic/global/menubuttonBindings.xml index 46bba22eff68..439f2823f703 100644 --- a/themes/classic/global/menubuttonBindings.xml +++ b/themes/classic/global/menubuttonBindings.xml @@ -8,7 +8,7 @@ - + - + @@ -119,7 +119,7 @@ - + @@ -128,8 +128,8 @@ - - + + @@ -173,7 +173,7 @@ diff --git a/themes/modern/communicator/menubuttonBindings.xml b/themes/modern/communicator/menubuttonBindings.xml index 959272a82f01..f25eb9e31ddb 100644 --- a/themes/modern/communicator/menubuttonBindings.xml +++ b/themes/modern/communicator/menubuttonBindings.xml @@ -9,7 +9,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey,disabled"/> @@ -21,7 +21,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey,disabled"/> diff --git a/themes/modern/global/globalBindings.xml b/themes/modern/global/globalBindings.xml index da68c75bcb58..d5c0fa46df43 100644 --- a/themes/modern/global/globalBindings.xml +++ b/themes/modern/global/globalBindings.xml @@ -19,13 +19,13 @@ - + - - + diff --git a/xpfe/communicator/resources/content/dialogBindings.xml b/xpfe/communicator/resources/content/dialogBindings.xml index d0ee0c09c9c9..58559583163b 100644 --- a/xpfe/communicator/resources/content/dialogBindings.xml +++ b/xpfe/communicator/resources/content/dialogBindings.xml @@ -8,9 +8,9 @@ - + - + @@ -40,7 +40,7 @@ - + diff --git a/xpfe/components/console/resources/content/consoleBindings.xml b/xpfe/components/console/resources/content/consoleBindings.xml index 7202e1a01d79..04a22c9bb7ac 100644 --- a/xpfe/components/console/resources/content/consoleBindings.xml +++ b/xpfe/components/console/resources/content/consoleBindings.xml @@ -15,20 +15,20 @@ - - + + - + - + - + - + diff --git a/xpfe/global/resources/content/dialogBindings.xml b/xpfe/global/resources/content/dialogBindings.xml index cf34641f8b05..7aafdf3c9117 100644 --- a/xpfe/global/resources/content/dialogBindings.xml +++ b/xpfe/global/resources/content/dialogBindings.xml @@ -8,9 +8,9 @@ - + - + @@ -38,7 +38,7 @@ - + diff --git a/xpfe/global/resources/content/menulistBindings.xml b/xpfe/global/resources/content/menulistBindings.xml index e90ef349d61b..b937c9fc4456 100644 --- a/xpfe/global/resources/content/menulistBindings.xml +++ b/xpfe/global/resources/content/menulistBindings.xml @@ -81,7 +81,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey"/> @@ -93,7 +93,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey"/> @@ -105,7 +105,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey"/> @@ -117,7 +117,7 @@ + inherits="tooltiptext=buttontooltiptext,oncommand=buttonaction,src,value,crop,accesskey"/> @@ -128,7 +128,7 @@ - - + @@ -226,7 +226,7 @@ Contributor(s): - diff --git a/xpfe/global/resources/content/xulBindings.xml b/xpfe/global/resources/content/xulBindings.xml index 391f0b8da976..bab321bc3427 100644 --- a/xpfe/global/resources/content/xulBindings.xml +++ b/xpfe/global/resources/content/xulBindings.xml @@ -71,7 +71,7 @@ - + - + - +