Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 14:22:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 108528 - knob is not defined doesn't explain to 2001110503 users what to do

Browse Source 
patch by caduvall@glue.umd.edu r=timeless a=justdave
This commit is contained in:
timeless%mozdev.org 2003-10-15 22:48:12 +00:00
parent 6984371fce
commit 19efc5771e
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webtools/bugzilla/CGI.pl
View File

@ -111,10 +111,11 @@ sub CheckFormField (\%$;\@) {
sub CheckFormFieldDefined (\%$) {
my ($formRef, # a reference to the form to check (a hash)
$fieldname, # the fieldname to check
$info, # (optional) error message to give
) = @_;
if (!defined $formRef->{$fieldname}) {
ThrowCodeError("undefined_field", { field => $fieldname });
ThrowCodeError("undefined_field", { field => $fieldname, info => $info });
}
}

2
webtools/bugzilla/process_bug.cgi
View File

@ -858,7 +858,7 @@ if (defined $::FORM{newcc} || defined $::FORM{removecc} || defined $::FORM{massc
}
CheckFormFieldDefined(\%::FORM, 'knob');
CheckFormFieldDefined(\%::FORM, 'knob', "check that \"Leave as...\" was selected.");
SWITCH: for ($::FORM{'knob'}) {
/^none$/ && do {
last SWITCH;

7
webtools/bugzilla/template/en/default/global/code-error.html.tmpl
View File

@ -208,7 +208,12 @@
I was unable to retrieve your old password from the database.
[% ELSIF error == "undefined_field" %]
[% field FILTER html %] was not defined; [% Param('browserbugmessage') %]
[% field FILTER html %] was not defined;
[% IF info %]
[% info FILTER html %]
[% ELSE %]
[% Param('browserbugmessage') %]
[% END %]
[% ELSIF error == "unknown_action" %]
[% IF action %]