From 1a1680a95bf8499c15cdffc53a90d255ad334c65 Mon Sep 17 00:00:00 2001 From: "lpsolit%gmail.com" Date: Tue, 19 Dec 2006 08:38:49 +0000 Subject: [PATCH] =?UTF-8?q?Bug=20364286:=20Code=20in=20Classification->pro?= =?UTF-8?q?ducts()=20is=20suboptimal=20-=20Patch=20by=20Fr=EF=BF=BD?= =?UTF-8?q?=EF=BF=BDd=EF=BF=BD=EF=BF=BDric=20Buclin=20?= =?UTF-8?q?=20r=3Dmkanat=20a=3Djustdave?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- webtools/bugzilla/Bugzilla/Classification.pm | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/webtools/bugzilla/Bugzilla/Classification.pm b/webtools/bugzilla/Bugzilla/Classification.pm index 3d264b704dff..37ae3a0cca57 100644 --- a/webtools/bugzilla/Bugzilla/Classification.pm +++ b/webtools/bugzilla/Bugzilla/Classification.pm @@ -106,12 +106,8 @@ sub products { SELECT id FROM products WHERE classification_id = ? ORDER BY name}, undef, $self->id); - - my @products; - foreach my $product_id (@$product_ids) { - push (@products, new Bugzilla::Product($product_id)); - } - $self->{'products'} = \@products; + + $self->{'products'} = Bugzilla::Product->new_from_list($product_ids); } return $self->{'products'}; }