From 1a94f267c62b170cc97a810c455c8a96fff204f7 Mon Sep 17 00:00:00 2001 From: "kestes%walrus.com" Date: Sat, 27 Apr 2002 04:55:37 +0000 Subject: [PATCH] Ignore build must allow spaces in buildnames. --- webtools/tinderbox2/src/bin/admintree.cgi | 9 +++++---- webtools/tinderbox2/src/bin/tinder.cgi | 9 ++++++--- webtools/tinderbox2/src/lib/TinderDB/Build.pm | 6 +++--- 3 files changed, 14 insertions(+), 10 deletions(-) diff --git a/webtools/tinderbox2/src/bin/admintree.cgi b/webtools/tinderbox2/src/bin/admintree.cgi index 83bae6d08a93..625d36c4d4c1 100755 --- a/webtools/tinderbox2/src/bin/admintree.cgi +++ b/webtools/tinderbox2/src/bin/admintree.cgi @@ -7,8 +7,8 @@ # columns from being shown on the default pages. -# $Revision: 1.19 $ -# $Date: 2002/04/26 22:42:44 $ +# $Revision: 1.20 $ +# $Date: 2002/04/27 04:55:37 $ # $Author: kestes%walrus.com $ # $Source: /home/hwine/cvs_conversion/cvsroot/mozilla/webtools/tinderbox2/src/bin/admintree.cgi,v $ # $Name: $ @@ -198,7 +198,7 @@ sub get_current_ignore_builds { my (@ignore_builds) = (); @ignore_builds = split( - /\s+/, + /,/, TinderHeader::gettree_header('IgnoreBuilds', $TREE) ); @@ -449,7 +449,8 @@ sub change_ignore_builds { ("@NEW_IGNORE_BUILDS" eq "@CURRENT_IGNORE_BUILDS") && return ; - TinderHeader::savetree_header('IgnoreBuilds', $TREE, "@NEW_IGNORE_BUILDS"); + $ignore_builds = join(',', @NEW_IGNORE_BUILDS); + TinderHeader::savetree_header('IgnoreBuilds', $TREE, $ignore_builds); push @results, "ignore_builds changed: @NEW_IGNORE_BUILDS \n"; diff --git a/webtools/tinderbox2/src/bin/tinder.cgi b/webtools/tinderbox2/src/bin/tinder.cgi index 340f41c66075..01e254c8426b 100755 --- a/webtools/tinderbox2/src/bin/tinder.cgi +++ b/webtools/tinderbox2/src/bin/tinder.cgi @@ -2,8 +2,8 @@ # -*- Mode: perl; indent-tabs-mode: nil -*- # -# $Revision: 1.23 $ -# $Date: 2002/04/27 04:24:43 $ +# $Revision: 1.24 $ +# $Date: 2002/04/27 04:55:37 $ # $Author: kestes%walrus.com $ # $Source: /home/hwine/cvs_conversion/cvsroot/mozilla/webtools/tinderbox2/src/bin/tinder.cgi,v $ # $Name: $ @@ -396,6 +396,7 @@ sub HTML_status_page { $out .= "\n\n"; $out .= "\n\n\n"; $out .= "$links\n"; + $out .= "
\n" $out .= "\n"; $out .= $motd; $out .= "

\n\n"; @@ -417,9 +418,11 @@ sub HTML_status_page { $out .= "\n\n"; $out .= "

\n"; $out .= $links; + $out .= "
\n" $out .= $previous_links; + $out .= "
\n" $out .= "\n"; - $out .= "Table Legend" + $out .= "Table Legend"; $out .= "\n"; $out .= " @legend\n\n"; $out .= "
\n\n"; diff --git a/webtools/tinderbox2/src/lib/TinderDB/Build.pm b/webtools/tinderbox2/src/lib/TinderDB/Build.pm index 9e9ba91a8ae7..8b783bf43b1b 100755 --- a/webtools/tinderbox2/src/lib/TinderDB/Build.pm +++ b/webtools/tinderbox2/src/lib/TinderDB/Build.pm @@ -7,8 +7,8 @@ # the build was and display a link to the build log. -# $Revision: 1.35 $ -# $Date: 2002/04/26 23:49:06 $ +# $Revision: 1.36 $ +# $Date: 2002/04/27 04:55:33 $ # $Author: kestes%walrus.com $ # $Source: /home/hwine/cvs_conversion/cvsroot/mozilla/webtools/tinderbox2/src/lib/TinderDB/Build.pm,v $ # $Name: $ @@ -379,7 +379,7 @@ sub compute_metadata { # order is important for these operations. my ($ignore_builds) = TinderHeader::gettree_header('IgnoreBuilds', $tree); - foreach $buildname (split(/\s+/, $ignore_builds)) { + foreach $buildname (split(/,/, $ignore_builds)) { $IGNORE_BUILDS{$tree}{$buildname} = 1; }