Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 05:45:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 965527 - Harden OS.File shutdown flag. r=froydnj

Browse Source
This commit is contained in:
David Rajchenbach-Teller 2014-03-06 12:50:28 -05:00
parent 34ce2db4d4
commit 1af328747f
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
toolkit/components/osfile/modules/osfile_async_front.jsm
View File

@ -200,7 +200,13 @@ let Scheduler = {
* the promise returned by |code|.
*/
push: function(code) {
let promise = this.queue.then(code);
let promise = this.queue.then(function() {
if (this.shutdown) {
LOG("OS.File is not available anymore. Request has been rejected.");
throw new Error("OS.File has been shut down.");
}
return code();
}.bind(this));
// By definition, |this.queue| can never reject.
this.queue = promise.then(null, () => undefined);
// Fork |promise| to ensure that uncaught errors are reported
@ -408,14 +414,13 @@ function warnAboutUnclosedFiles(shutdown = true) {
// Don't launch the scheduler on our behalf. If no message has been
// sent to the worker, we can't have any leaking file/directory
// descriptor.
Scheduler.shutdown = Scheduler.shutdown || shutdown;
return null;
}
let promise = Scheduler.post("Meta_getUnclosedResources");
// Configure the worker to reject any further message.
if (shutdown) {
Scheduler.shutdown = true;
}
Scheduler.shutdown = Scheduler.shutdown || shutdown;
return promise.then(function onSuccess(opened) {
let msg = "";