Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 23:05:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 778263 - Clean up SelectionHandler data when we bail in startSelection. r=mfinkle

Browse Source
This commit is contained in:
Margaret Leibovic 2012-08-07 11:20:11 -07:00
parent 9f556de8de
commit 1b2c2dc75a
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
mobile/android/chrome/content/browser.js
View File

@ -1683,13 +1683,14 @@ var SelectionHandler = {
selectionController.wordMove(!this._isRTL, true);
} catch(e) {
// If we couldn't select the word at the given point, bail
Cu.reportError("Error selecting word: " + e);
this._cleanUp();
return;
}
// If there isn't an appropriate selection, bail
if (!selection.rangeCount || !selection.getRangeAt(0) || !selection.toString().trim().length) {
selection.collapseToStart();
this._cleanUp();
return;
}
@ -1838,13 +1839,17 @@ var SelectionHandler = {
}
}
this._cleanUp();
return selectedText;
},
_cleanUp: function sh_cleanUp() {
this._view.removeEventListener("pagehide", this, false);
this._view = null;
this._target = null;
this._isRTL = false;
this.cache = null;
return selectedText;
},
_getViewOffset: function sh_getViewOffset() {