Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-03 18:47:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1759432 - Don't check for the WebVR pref in VRProcessChild::Init. r=jgilbert

Browse Source 
This check seems to fail even if the VR pref is enabled. I think this is
because we are running this code while very early in process startup.
I think it will not introduce risk because the other process in this case
will be the parent process, so if that's been taken over then we've already
lost.

This also seems to fix the leak that I had to ignore before, probably
because the VR process wasn't even starting up properly before, so I've
removed the leak threshold I had to add.

Differential Revision: https://phabricator.services.mozilla.com/D141170
This commit is contained in:
Andrew McCreight 2022-03-16 14:36:39 +00:00
parent 7471bb6338
commit 1b5cf10537
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gfx/vr/ipc/VRProcessChild.cpp
View File

@ -30,11 +30,6 @@ VRParent* VRProcessChild::GetVRParent() {
}
bool VRProcessChild::Init(int aArgc, char* aArgv[]) {
if (!StaticPrefs::dom_vr_enabled() && !StaticPrefs::dom_vr_webxr_enabled()) {
NS_WARNING("VR is not enabled when trying to create a VRParent");
return false;
}
Maybe<const char*> parentBuildID =
geckoargs::sParentBuildID.Get(aArgc, aArgv);
if (parentBuildID.isNothing()) {

1
testing/web-platform/meta/webvr/__dir__.ini
View File

@ -1,2 +1 @@
prefs: [dom.vr.enabled:true, dom.vr.prompt.testing:true, dom.vr.prompt.testing.allow:true, dom.security.featurePolicy.experimental.enabled:true, dom.security.featurePolicy.header.enabled:true, dom.security.featurePolicy.webidl.enabled:true]
leak-threshold: [vr:500]