Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-22 09:45:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1539654: Improve error messages from SpiderMonkey test Match library. r=jorendorff

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D32393

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Jim Blandy 2019-06-10 18:51:30 +00:00
parent 626777ab35
commit 1c4edbdc73
1 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
js/src/tests/non262/reflect-parse/Match.js
View File

@ -62,12 +62,8 @@ var Match =
var quote = uneval;
function MatchError(msg) {
this.message = msg;
}
MatchError.prototype = {
toString: function() {
class MatchError extends Error {
toString() {
return "match error: " + this.message;
}
};
@ -137,7 +133,15 @@ var Match =
for (var key in exp) {
if (!(key in act))
throw new MatchError("expected property " + quote(key) + " not found in " + quote(act));
match(act[key], exp[key]);
try {
match(act[key], exp[key]);
} catch (inner) {
if (!(inner instanceof MatchError)) {
throw inner;
}
inner.message = `matching property ${uneval(key)}:\n${inner.message}`;
throw inner;
}
}
return true;
@ -164,7 +168,15 @@ var Match =
if (i in exp) {
if (!(i in act))
throw new MatchError("expected array property " + i + " not found in " + quote(act));
match(act[i], exp[i]);
try {
match(act[i], exp[i]);
} catch (inner) {
if (!(inner instanceof MatchError)) {
throw inner;
}
inner.message = `matching array element [${i}]:\n${inner.message}`;
throw inner;
}
}
}