Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 11:25:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Leak fixing. CreateNewTopLevel window returns an AddReffed window. You must release it. Also added comments to get the author to think about ownership.

Browse Source
This commit is contained in:
sfraser%netscape.com 1999-06-19 22:07:48 +00:00
parent b400f22d26
commit 1c9e290085
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
xpinstall/src/nsXPInstallManager.cpp
View File

@ -363,12 +363,11 @@ nsXPInstallManager::BeforeJavascriptEvaluation()
if ( NS_SUCCEEDED(rv) )
{
nsIWebShellWindow *newWindow;
nsCOMPtr<nsIWebShellWindow> newWindow;
rv = appShell->CreateTopLevelWindow( nsnull,
url,
PR_TRUE,
newWindow,
*getter_AddRefs(newWindow),
nsnull,
this, // callbacks??
0,
@ -376,9 +375,7 @@ nsXPInstallManager::BeforeJavascriptEvaluation()
if ( NS_SUCCEEDED( rv ) )
{
mWindow = newWindow;
NS_RELEASE( newWindow );
mWindow = newWindow; // ownership ?
if (mWindow != nsnull)
mWindow->Show(PR_TRUE);
}