Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-03 07:01:19 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1846343 - [remote] Do not emit network events for discarded browsing contexts r=webdriver-reviewers,whimboo

Browse Source 
Depends on D187477

Differential Revision: https://phabricator.services.mozilla.com/D187478
This commit is contained in:
Julian Descottes 2023-09-08 13:21:17 +00:00
parent 3f9f4304ec
commit 1cecc01304
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
remote/webdriver-bidi/modules/root/network.sys.mjs
View File

@ -447,6 +447,13 @@ class NetworkModule extends Module {
timestamp,
} = data;
const browsingContext = lazy.TabManager.getBrowsingContextById(contextId);
if (!browsingContext) {
// Do not emit events if the context id does not match any existing
// browsing context.
return;
}
const protocolEventName = "network.beforeRequestSent";
const isListening = this.messageHandler.eventsDispatcher.hasListener(
protocolEventName,
@ -476,7 +483,6 @@ class NetworkModule extends Module {
initiator,
});
const browsingContext = lazy.TabManager.getBrowsingContextById(contextId);
this.emitEvent(
protocolEventName,
beforeRequestSentEvent,
@ -511,6 +517,13 @@ class NetworkModule extends Module {
timestamp,
} = data;
const browsingContext = lazy.TabManager.getBrowsingContextById(contextId);
if (!browsingContext) {
// Do not emit events if the context id does not match any existing
// browsing context.
return;
}
const protocolEventName =
name === "response-started"
? "network.responseStarted"
@ -538,7 +551,6 @@ class NetworkModule extends Module {
response: responseData,
});
const browsingContext = lazy.TabManager.getBrowsingContextById(contextId);
this.emitEvent(
protocolEventName,
responseEvent,