Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-16 06:45:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

#112973, we leak the whole file on upload (of, for example a patch in bugzilla).

Browse Source 
r=bzbarsky, sr=attinasi
This commit is contained in:
hwaara%chello.se 2001-12-17 22:21:38 +00:00
parent 073a7c9d91
commit 1d2ac8f02c
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
content/html/content/src/nsFormSubmitter.cpp
View File

@ -1063,15 +1063,18 @@ nsFormSubmitter::ProcessAsMultipart(nsIForm* form,
}
// Print file contents
PRInt32 size = 1;
char* readbuffer = nsnull;
while (1) {
char* readbuffer = nsnull;
// Read() mallocs if readbuffer is null
rv = contentFile->Read(&readbuffer, BUFSIZE, &size);
if (NS_FAILED(rv) || 0 >= size) break;
wantbytes = size;
rv = outStream->Write(readbuffer, wantbytes, &gotbytes);
if (NS_FAILED(rv) || (wantbytes != gotbytes)) break;
}
nsMemory::Free(readbuffer);
NS_RELEASE(contentFile);
if (NS_FAILED(rv)) break;
// Print CRLF after file
wantbytes = PL_strlen(CRLF);
rv = outStream->Write(CRLF, wantbytes, &gotbytes);