Bug 1535350 - remove win32-clang-tidy job; r=dmajor

Updating clang indicates that 32-bit compilation is substantially longer
than 64-bit compilation, perhaps due to swapping.  The compilation
process is hitting the timeout limit shortly before the compilation
process completes (~3681/3695 tasks according to ninja).

We could tweak our clang build process to accommodate this job.  But we
don't support building on 32-bit Windows anymore, and we don't produce a
32-bit Windows clang either.  So we shouldn't support a 32-bit Windows
clang-tidy job either.  Let's get rid of it.

Differential Revision: https://phabricator.services.mozilla.com/D23517

--HG--
extra : moz-landing-system : lando

build/build-clang/clang-tidy-win32.json

@@ -1,18 +0,0 @@
-{
-    "llvm_revision": "349247",
-    "stages": "1",
-    "build_libcxx": false,
-    "build_type": "Release",
-    "assertions": false,
-    "build_clang_tidy": true,
-    "llvm_repo": "https://llvm.org/svn/llvm-project/llvm/tags/RELEASE_701/final",
-    "clang_repo": "https://llvm.org/svn/llvm-project/cfe/tags/RELEASE_701/final",
-    "extra_repo": "https://llvm.org/svn/llvm-project/clang-tools-extra/tags/RELEASE_701/final",
-    "compiler_repo": "https://llvm.org/svn/llvm-project/compiler-rt/tags/RELEASE_701/final",
-    "libcxx_repo": "https://llvm.org/svn/llvm-project/libcxx/tags/RELEASE_701/final",
-    "python_path": "c:/mozilla-build/python/python.exe",
-    "cc": "cl.exe",
-    "cxx": "cl.exe",
-    "patches": [
-    ]
-}

taskcluster/ci/toolchain/clang-tidy.yml

@@ -58,25 +58,6 @@ macosx64-clang-tidy:
         - linux64-gcc-4.9
         - linux64-node
 
-win32-clang-tidy:
-    description: "Clang-tidy toolchain build"
-    index:
-        job-name: win32-clang-tidy
-    treeherder:
-        symbol: TW32(clang-tidy)
-        tier: 2
-    worker-type: aws-provisioner-v1/gecko-{level}-b-win2012
-    worker:
-        max-run-time: 7200
-        env:
-            TOOLTOOL_MANIFEST: "browser/config/tooltool-manifests/win32/build-clang-cl.manifest"
-    run:
-        script: build-clang-tidy32-windows.sh
-        resources:
-            - 'build/build-clang/clang-tidy-win32.json'
-            - 'taskcluster/scripts/misc/build-clang-windows-helper32.sh'
-        toolchain-artifact: public/build/clang-tidy.tar.bz2
-
 win64-clang-tidy:
     description: "Clang-tidy toolchain build"
     index:

taskcluster/scripts/misc/build-clang-tidy32-windows.sh

@@ -1,3 +0,0 @@
-#!/bin/bash
-
-source build/src/taskcluster/scripts/misc/build-clang-windows-helper32.sh clang-tidy-win32.json

taskcluster/scripts/misc/build-clang-windows-helper32.sh

@@ -1,63 +0,0 @@
-#!/bin/bash
-
-set -x -e -v
-
-# This script is for building clang-cl on Windows.
-
-: TOOLTOOL_CACHE                ${TOOLTOOL_CACHE:=/builds/worker/tooltool-cache}
-export TOOLTOOL_CACHE
-
-TOOLTOOL_AUTH_FILE=/c/builds/relengapi.tok
-if [ ! -e ${TOOLTOOL_AUTH_FILE} ]; then
-    echo cannot find ${TOOLTOOL_AUTH_FILE}
-    exit 1
-fi
-
-./build/src/mach artifact toolchain -v --authentication-file="${TOOLTOOL_AUTH_FILE}" --tooltool-manifest "build/src/${TOOLTOOL_MANIFEST}"${TOOLTOOL_CACHE:+ --cache-dir ${TOOLTOOL_CACHE}}${MOZ_TOOLCHAINS:+ ${MOZ_TOOLCHAINS}}
-
-# Set up all the Visual Studio paths.
-MSVC_DIR=vs2017_15.8.4
-VSWINPATH="$(cd ${MSVC_DIR} && pwd)"
-
-echo vswinpath ${VSWINPATH}
-
-# LLVM_ENABLE_DIA_SDK is set if the directory "$ENV{VSINSTALLDIR}DIA SDK"
-# exists.
-export VSINSTALLDIR="${VSWINPATH}/"
-
-export WINDOWSSDKDIR="${VSWINPATH}/SDK"
-export WIN32_REDIST_DIR="${VSWINPATH}/VC/redist/x86/Microsoft.VC141.CRT"
-export WIN_UCRT_REDIST_DIR="${VSWINPATH}/SDK/Redist/ucrt/DLLs/x86"
-
-export PATH="${VSWINPATH}/VC/bin/Hostx64/x86:${VSWINPATH}/VC/bin/Hostx64/x64:${VSWINPATH}/SDK/bin/10.0.17134.0/x64:${VSWINPATH}/DIA SDK/bin:${PATH}"
-export PATH="${VSWINPATH}/VC/redist/x86/Microsoft.VC141.CRT:${VSWINPATH}/SDK/Redist/ucrt/DLLs/x86:${PATH}"
-
-export INCLUDE="${VSWINPATH}/VC/include:${VSWINPATH}/VC/atlmfc/include:${VSWINPATH}/SDK/Include/10.0.17134.0/ucrt:${VSWINPATH}/SDK/Include/10.0.17134.0/shared:${VSWINPATH}/SDK/Include/10.0.17134.0/um:${VSWINPATH}/SDK/Include/10.0.17134.0/winrt:${VSWINPATH}/DIA SDK/include"
-export LIB="${VSWINPATH}/VC/lib/x86:${VSWINPATH}/VC/atlmfc/lib/x86:${VSWINPATH}/SDK/Lib/10.0.17134.0/ucrt/x86:${VSWINPATH}/SDK/Lib/10.0.17134.0/um/x86:${VSWINPATH}/DIA SDK/lib"
-
-export PATH="$(cd svn && pwd)/bin:${PATH}"
-export PATH="$(cd cmake && pwd)/bin:${PATH}"
-export PATH="$(cd ninja && pwd)/bin:${PATH}"
-
-# We use |mach python| to set up a virtualenv automatically for us.  We create
-# a dummy mozconfig, because the default machinery for config.guess-choosing
-# of the objdir doesn't work very well.
-MOZCONFIG="$(pwd)/mozconfig"
-cat > ${MOZCONFIG} <<EOF
-mk_add_options MOZ_OBJDIR=$(pwd)/objdir
-EOF
-
-# gets a bit too verbose here
-set +x
-
-BUILD_CLANG_DIR=build/src/build/build-clang
-cd ${BUILD_CLANG_DIR}
-MOZCONFIG=${MOZCONFIG} ../../mach python ./build-clang.py -c ./${1}
-cd -
-
-set -x
-
-# Put a tarball in the artifacts dir
-UPLOAD_PATH=public/build
-mkdir -p ${UPLOAD_PATH}
-cp ${BUILD_CLANG_DIR}/clang*.tar.* ${UPLOAD_PATH}