Backed out changeset 773f5b2cb868 (bug 1355430) for unexpectedly passing own test dom/canvas/test/webgl-mochitest/test_video_fastpath_mp4.html on Windows. r=backout

This commit is contained in:
Sebastian Hengst 2017-04-18 21:09:25 +02:00
parent e4c87ce902
commit 1dd0176f22
8 changed files with 18 additions and 19 deletions

View File

@ -1272,8 +1272,8 @@ DOMInterfaces = {
'headerFile': 'WebGLExtensions.h'
},
'MOZ_debug': {
'nativeType': 'mozilla::WebGLExtensionMOZDebug',
'MOZ_debug_get': {
'nativeType': 'mozilla::WebGLExtensionDebugGet',
'headerFile': 'WebGLExtensions.h'
},

View File

@ -40,7 +40,7 @@ WebGLContext::GetExtensionString(WebGLExtensionID ext)
WEBGL_EXTENSION_IDENTIFIER(EXT_sRGB)
WEBGL_EXTENSION_IDENTIFIER(EXT_texture_filter_anisotropic)
WEBGL_EXTENSION_IDENTIFIER(EXT_disjoint_timer_query)
WEBGL_EXTENSION_IDENTIFIER(MOZ_debug)
WEBGL_EXTENSION_IDENTIFIER(MOZ_debug_get)
WEBGL_EXTENSION_IDENTIFIER(OES_element_index_uint)
WEBGL_EXTENSION_IDENTIFIER(OES_standard_derivatives)
WEBGL_EXTENSION_IDENTIFIER(OES_texture_float)
@ -91,7 +91,7 @@ bool WebGLContext::IsExtensionSupported(dom::CallerType callerType,
if (allowPrivilegedExts) {
switch (ext) {
case WebGLExtensionID::MOZ_debug:
case WebGLExtensionID::MOZ_debug_get:
return true;
case WebGLExtensionID::WEBGL_debug_renderer_info:
return true;
@ -381,8 +381,8 @@ WebGLContext::EnableExtension(WebGLExtensionID ext)
break;
// MOZ_
case WebGLExtensionID::MOZ_debug:
obj = new WebGLExtensionMOZDebug(this);
case WebGLExtensionID::MOZ_debug_get:
obj = new WebGLExtensionDebugGet(this);
break;
// OES_

View File

@ -6,23 +6,22 @@
#include "WebGLExtensions.h"
#include "mozilla/dom/WebGLRenderingContextBinding.h"
#include "GLContext.h"
#include "WebGLContext.h"
#include "WebGLContextUtils.h"
namespace mozilla {
WebGLExtensionMOZDebug::WebGLExtensionMOZDebug(WebGLContext* webgl)
WebGLExtensionDebugGet::WebGLExtensionDebugGet(WebGLContext* webgl)
: WebGLExtensionBase(webgl)
{
}
WebGLExtensionMOZDebug::~WebGLExtensionMOZDebug()
WebGLExtensionDebugGet::~WebGLExtensionDebugGet()
{
}
void
WebGLExtensionMOZDebug::GetParameter(JSContext* cx, GLenum pname,
WebGLExtensionDebugGet::GetParameter(JSContext* cx, GLenum pname,
JS::MutableHandle<JS::Value> retval,
ErrorResult& er) const
{
@ -69,12 +68,12 @@ WebGLExtensionMOZDebug::GetParameter(JSContext* cx, GLenum pname,
}
default:
mContext->ErrorInvalidEnumArg("MOZ_debug.getParameter", "pname", pname);
mContext->ErrorInvalidEnumArg("MOZ_debug_get.getParameter", "pname", pname);
retval.set(JS::NullValue());
return;
}
}
IMPL_WEBGL_EXTENSION_GOOP(WebGLExtensionMOZDebug, MOZ_debug)
IMPL_WEBGL_EXTENSION_GOOP(WebGLExtensionDebugGet, MOZ_debug_get)
} // namespace mozilla

View File

@ -404,12 +404,12 @@ public:
DECL_WEBGL_EXTENSION_GOOP
};
class WebGLExtensionMOZDebug final
class WebGLExtensionDebugGet final
: public WebGLExtensionBase
{
public:
explicit WebGLExtensionMOZDebug(WebGLContext* webgl);
virtual ~WebGLExtensionMOZDebug();
explicit WebGLExtensionDebugGet(WebGLContext* webgl);
virtual ~WebGLExtensionDebugGet();
void GetParameter(JSContext* cx, GLenum pname,
JS::MutableHandle<JS::Value> retval, ErrorResult& er) const;

View File

@ -149,7 +149,7 @@ enum class WebGLExtensionID : uint8_t {
EXT_shader_texture_lod,
EXT_texture_filter_anisotropic,
EXT_disjoint_timer_query,
MOZ_debug,
MOZ_debug_get,
OES_element_index_uint,
OES_standard_derivatives,
OES_texture_float,

View File

@ -135,6 +135,7 @@ UNIFIED_SOURCES += [
'WebGLExtensionCompressedTextureETC1.cpp',
'WebGLExtensionCompressedTexturePVRTC.cpp',
'WebGLExtensionCompressedTextureS3TC.cpp',
'WebGLExtensionDebugGet.cpp',
'WebGLExtensionDebugRendererInfo.cpp',
'WebGLExtensionDebugShaders.cpp',
'WebGLExtensionDepthTexture.cpp',
@ -145,7 +146,6 @@ UNIFIED_SOURCES += [
'WebGLExtensionFragDepth.cpp',
'WebGLExtensionInstancedArrays.cpp',
'WebGLExtensionLoseContext.cpp',
'WebGLExtensionMOZDebug.cpp',
'WebGLExtensionShaderTextureLod.cpp',
'WebGLExtensionSRGB.cpp',
'WebGLExtensionStandardDerivatives.cpp',

View File

@ -1085,7 +1085,7 @@ interface EXT_disjoint_timer_query {
};
[NoInterfaceObject]
interface MOZ_debug {
interface MOZ_debug_get {
const GLenum EXTENSIONS = 0x1F03;
const GLenum WSI_INFO = 0x10000;

View File

@ -494,7 +494,7 @@ var dataProviders = {
// //
let ext = gl.getExtension("MOZ_debug");
let ext = gl.getExtension("MOZ_debug_get");
// This extension is unconditionally available to chrome. No need to check.
let vendor = ext.getParameter(gl.VENDOR);
let renderer = ext.getParameter(gl.RENDERER);