Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-26 06:11:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix CheckSideEffects over-aggressiveness (383674, r=mrbkap).

Browse Source
This commit is contained in:
brendan@mozilla.org 2007-06-12 01:26:26 -07:00
parent 48e93e5ace
commit 1e95e50e45
1 changed files with 13 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
js/src/jsemit.c
View File

@ -2212,28 +2212,18 @@ CheckSideEffects(JSContext *cx, JSTreeContext *tc, JSParseNode *pn,
if (!CheckSideEffects(cx, tc, pn->pn_right, answer))
return JS_FALSE;
if (!*answer &&
(pn2->pn_slot < 0 || !(pn2->pn_attrs & JSPROP_READONLY))) {
(pn->pn_op != JSOP_NOP ||
pn2->pn_slot < 0 ||
!(pn2->pn_attrs & JSPROP_READONLY))) {
*answer = JS_TRUE;
}
}
} else {
if (pn->pn_type == TOK_LB) {
pn2 = pn->pn_left;
if (pn2->pn_type == TOK_NAME &&
!BindNameToSlot(cx, tc, pn2, 0)) {
return JS_FALSE;
}
if (pn2->pn_op != JSOP_ARGUMENTS) {
/*
* Any indexed property reference could call a getter with
* side effects, except for arguments[i] where arguments is
* unambiguous.
*/
*answer = JS_TRUE;
}
}
ok = CheckSideEffects(cx, tc, pn->pn_left, answer) &&
CheckSideEffects(cx, tc, pn->pn_right, answer);
/*
* We can't easily prove that neither operand ever denotes an
* object with a toString or valueOf method.
*/
*answer = JS_TRUE;
}
break;
@ -2266,7 +2256,11 @@ CheckSideEffects(JSContext *cx, JSTreeContext *tc, JSParseNode *pn,
break;
}
} else {
ok = CheckSideEffects(cx, tc, pn->pn_kid, answer);
/*
* We can't easily prove that our operand never denotes an object
* with a toString or valueOf method.
*/
*answer = JS_TRUE;
}
break;