Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 05:11:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1364097 - Do not show the autocomplete popup when input is empty. r=jdescottes

Browse Source 
MozReview-Commit-ID: JCE5eWPKu8l
This commit is contained in:
Ruturaj K. Vartak 2017-05-19 09:46:00 +01:00
parent f9087690d7
commit 1ed19ed100
2 changed files with 18 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
devtools/client/shared/components/search-box.js
View File

@ -149,6 +149,8 @@ module.exports = createClass({
let { value } = this.state;
let divClassList = ["devtools-searchbox", "has-clear-btn"];
let inputClassList = [`devtools-${type}input`];
let showAutocomplete =
autocompleteList.length > 0 && this.state.focused && value !== "";
if (value !== "") {
inputClassList.push("filled");
@ -170,8 +172,7 @@ module.exports = createClass({
hidden: value == "",
onClick: this.onClearButtonClick
}),
autocompleteList.length > 0 && this.state.focused &&
AutocompletePopup({
showAutocomplete && AutocompletePopup({
list: autocompleteList,
filter: value,
ref: "autocomplete",

29
devtools/client/shared/components/test/mochitest/test_searchbox-with-autocomplete.html
View File

@ -51,6 +51,11 @@ window.onload = async function () {
"pqr",
"xyz",
"ABC",
"a1",
"a2",
"a3",
"a4",
"a5",
],
onChange: () => null,
});
@ -61,15 +66,19 @@ window.onload = async function () {
$(".devtools-searchinput").focus();
await forceRender(component); // Wait for state update
ok(!$(".devtools-autocomplete-popup"), "Autocomplete list not visible");
sendString("a");
await forceRender(component);
compareAutocompleteList($(".devtools-autocomplete-listbox"), [
"ABC",
"BAR",
"a1",
"a2",
"a3",
"a4",
"a5",
"abc",
"baZ",
"foo",
"pqr",
"xyz",
]);
is(refs.autocomplete.state.selectedIndex, -1, "Initialised selectedIndex is -1");
@ -82,16 +91,8 @@ window.onload = async function () {
}
async function testKeyEventsWithAutocomplete() {
// Filtering of list
$(".devtools-searchinput").focus();
await forceRender(component);
sendString("aB");
await forceRender(component);
compareAutocompleteList($(".devtools-autocomplete-listbox"), ["ABC", "abc"]);
// Clear the initial input
synthesizeKey("VK_BACK_SPACE", {});
synthesizeKey("VK_BACK_SPACE", {});
$(".devtools-searchinput").focus();
// ArrowDown
synthesizeKey("VK_DOWN", {});