mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-08 02:14:43 +00:00
Bug 1607843 - Add instructions for running ESLint as well if JavaScript changes are also made. r=geckoview-reviewers,agi
Originally submitted as PR on documentation site by @jonalmeida. Differential Revision: https://phabricator.services.mozilla.com/D59300 --HG-- extra : moz-landing-system : lando
This commit is contained in:
parent
f23ed2d822
commit
1f0a7e46ff
@ -80,7 +80,7 @@ Now you're set up and ready to go.
|
||||
|
||||
One you have got GeckoView building and running, you will want to start contributing. There is a general guide to [Performing a Bug Fix for Git Developers](contributing-to-mc) for you to follow. To contribute to GeckoView specifically, you will need the following additional information.
|
||||
|
||||
### Running tests locally
|
||||
### Running tests and linter locally
|
||||
|
||||
To ensure that your patch does not break existing functionality in GeckoView, you can run the junit test suite with the following command
|
||||
|
||||
@ -95,6 +95,12 @@ This command also allows you to run individual tests or test classes, e.g.
|
||||
./mach geckoview-junit org.mozilla.geckoview.test.NavigationDelegateTest#loadUnknownHost
|
||||
```
|
||||
|
||||
If your patch makes a GeckoView JavaScript module, you should run ESLint as well:
|
||||
|
||||
```
|
||||
./mach lint -l eslint mobile/android/modules/geckoview/
|
||||
```
|
||||
|
||||
To see information on other options, simply run `./mach geckoview-junit --help`; of particular note for dealing with intermittent test failures are `--repeat N` and `--run-until-failure`, both of which do exactly what you’d expect.
|
||||
|
||||
### Updating the changelog and API documentation
|
||||
|
Loading…
Reference in New Issue
Block a user