Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 09:15:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1516228 - Use llvm-objdump for mac in dependentlibs.py, too. r=firefox-build-system-reviewers,mshal

Browse Source 
Depends on D17464

Differential Revision: https://phabricator.services.mozilla.com/D17465

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Mike Hommey 2019-01-24 15:54:05 +00:00
parent 2bb9d2d602
commit 1fc4b9344e
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
toolkit/library/dependentlibs.py
View File

@ -51,13 +51,14 @@ def dependentlibs_readelf(lib):
proc.wait()
return deps
def dependentlibs_otool(lib):
def dependentlibs_mac_objdump(lib):
'''Returns the list of dependencies declared in the given MACH-O dylib'''
proc = subprocess.Popen([substs['OTOOL'], '-l', lib], stdout = subprocess.PIPE)
deps= []
proc = subprocess.Popen([substs['LLVM_OBJDUMP'], '--private-headers', lib], stdout = subprocess.PIPE)
deps = []
cmd = None
for line in proc.stdout:
# otool -l output contains many different things. The interesting data
# llvm-objdump --private-headers output contains many different
# things. The interesting data
# is under "Load command n" sections, with the content:
# cmd LC_LOAD_DYLIB
# cmdsize 56
@ -100,7 +101,7 @@ def gen_list(output, lib):
if binary_type == ELF:
func = dependentlibs_readelf
elif binary_type == MACHO:
func = dependentlibs_otool
func = dependentlibs_mac_objdump
else:
ext = os.path.splitext(lib)[1]
assert(ext == '.dll')