Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 03:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1558758: narrow visibility from SnowWhiteKiller::MaybeKillObject to private.

Browse Source 
Simplifies reasoning about the method.

Differential Revision: https://phabricator.services.mozilla.com/D34685
This commit is contained in:
Mirko Brodesser 2019-06-11 17:15:07 +02:00
parent c1c3acd11d
commit 20b754bf1d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
xpcom/base/nsCycleCollector.cpp
View File

@ -2417,6 +2417,7 @@ class SnowWhiteKiller : public TraceCallbacks {
}
}
private:
void MaybeKillObject(SnowWhiteObject& aObject) {
if (!aObject.mRefCnt->get() && !aObject.mRefCnt->IsInPurpleBuffer()) {
mCollector->RemoveObjectFromGraph(aObject.mPointer);
@ -2429,6 +2430,7 @@ class SnowWhiteKiller : public TraceCallbacks {
}
}
public:
bool Visit(nsPurpleBuffer& aBuffer, nsPurpleBufferEntry* aEntry) {
// The cycle collector does not collect anything when recording/replaying.
if (recordreplay::IsRecordingOrReplaying()) {