Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-18 15:55:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1094812 - Remove now unused PlacesTransactions.RemoveBookmarksForUrls. r=mak

Browse Source 
MozReview-Commit-ID: HFAQCIbbT5E

--HG--
extra : rebase_source : 35ec6a1d25f2ce4e07f5f99f0f3fa064462a9c29
This commit is contained in:
Mark Banner 2017-07-31 16:26:21 +01:00
parent 78d5f1bdd0
commit 20ffb68786
2 changed files with 0 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
toolkit/components/places/PlacesTransactions.jsm
View File

@ -1476,25 +1476,6 @@ PT.Remove.prototype = {
}
};
/**
* Transactions for removing all bookmarks for one or more urls.
*
* Required Input Properties: urls.
*/
PT.RemoveBookmarksForUrls = DefineTransaction(["urls"]);
PT.RemoveBookmarksForUrls.prototype = {
async execute({ urls }) {
let guids = [];
for (let url of urls) {
await PlacesUtils.bookmarks.fetch({ url }, b => guids.push(b.guid));
}
let removeTxn = TransactionsHistory.getRawTransaction(PT.Remove(guids));
await removeTxn.execute();
this.undo = removeTxn.undo.bind(removeTxn);
this.redo = removeTxn.redo.bind(removeTxn);
}
};
/**
* Transaction for tagging urls.
*

33
toolkit/components/places/tests/unit/test_async_transactions.js
View File

@ -1689,36 +1689,3 @@ add_task(async function test_remove_multiple() {
await PT.clearTransactionsHistory();
observer.reset();
});
add_task(async function test_remove_bookmarks_for_urls() {
let urls = [new URL("http://test.url.1"), new URL("http://test.url.2")];
let guids = [];
await PT.batch(async function() {
for (let url of urls) {
for (let title of ["test title a", "test title b"]) {
let txn = PT.NewBookmark({ url, title, parentGuid: rootGuid });
guids.push(await txn.transact());
}
}
});
let originalInfos = [];
for (let guid of guids) {
originalInfos.push(await PlacesUtils.promiseBookmarksTree(guid));
}
await PT.RemoveBookmarksForUrls(urls).transact();
await ensureNonExistent(...guids);
await PT.undo();
await ensureBookmarksTreeRestoredCorrectly(...originalInfos);
await PT.redo();
await ensureNonExistent(...guids);
await PT.undo();
await ensureBookmarksTreeRestoredCorrectly(...originalInfos);
// Cleanup.
await PT.redo();
await ensureNonExistent(...guids);
await PT.clearTransactionsHistory();
observer.reset();
});