Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-01 13:57:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 771934 - Throw NOT_FOUND_ERR instead of HIERARCHY_REQUEST_ERR from nsINode::RemoveChild; r=bz

Browse Source
This commit is contained in:
Ms2ger 2012-08-04 09:43:59 +02:00
parent 6113a6857c
commit 215c4e9e59
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
content/base/src/nsINode.cpp
View File

@ -437,10 +437,11 @@ nsINode::RemoveChild(nsINode *aOldChild)
}
if (IsNodeOfType(eDATA_NODE)) {
return NS_ERROR_DOM_HIERARCHY_REQUEST_ERR;
// aOldChild can't be one of our children.
return NS_ERROR_DOM_NOT_FOUND_ERR;
}
if (aOldChild && aOldChild->GetNodeParent() == this) {
if (aOldChild->GetNodeParent() == this) {
nsContentUtils::MaybeFireNodeRemoved(aOldChild, this, OwnerDoc());
}

2
dom/imptests/failures/webapps/DOMCore/tests/submissions/Ms2ger/test_Node-removeChild.html.json
View File

@ -1,5 +1,3 @@
{
"Calling removeChild on a comment with no children should throw NOT_FOUND_ERR.": true,
"Calling removeChild on a text with no children should throw NOT_FOUND_ERR.": true,
"Passing a value that is not a Node reference to removeChild should throw TypeError.": true
}