Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1483953 - Add a FixIt hint for the ExplicitImplicitChecker analysis. r=Ehsan

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D4191

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Andi-Bogdan Postelnicu 2018-08-24 14:11:26 +00:00
parent 6ac001b7a4
commit 2238536677
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
build/clang-plugin/ExplicitImplicitChecker.cpp
View File

@ -24,10 +24,13 @@ void ExplicitImplicitChecker::check(const MatchFinder::MatchResult &Result) {
const CXXRecordDecl *Declaration = const CXXRecordDecl *Declaration =
Result.Nodes.getNodeAs<CXXRecordDecl>("class"); Result.Nodes.getNodeAs<CXXRecordDecl>("class");
FixItHint FixItHint =
FixItHint::CreateInsertion(Ctor->getLocation(), "explicit ");
diag(Ctor->getLocation(), "bad implicit conversion constructor for %0", diag(Ctor->getLocation(), "bad implicit conversion constructor for %0",
DiagnosticIDs::Error) DiagnosticIDs::Error)
<< Declaration->getDeclName(); << Declaration->getDeclName();
diag(Ctor->getLocation(), diag(Ctor->getLocation(),
"consider adding the explicit keyword to the constructor", "consider adding the explicit keyword to the constructor",
DiagnosticIDs::Note); DiagnosticIDs::Note)
<< FixItHint;
} }