diff --git a/.eslintignore b/.eslintignore
index db3ebf0f518d..727765d6c4c8 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -70,6 +70,8 @@ browser/components/sessionstore/**
browser/components/tabview/**
browser/components/translation/**
browser/extensions/pdfjs/**
+# generated or library files in pocket
+browser/extensions/pocket/content/panels/js/tmpl.js
browser/extensions/pocket/content/panels/js/vendor/**
browser/locales/**
diff --git a/b2g/config/aries/sources.xml b/b2g/config/aries/sources.xml
index 9cb26206071f..0ed0a67a603c 100644
--- a/b2g/config/aries/sources.xml
+++ b/b2g/config/aries/sources.xml
@@ -8,7 +8,7 @@
-
+
diff --git a/b2g/config/nexus-5-l/sources.xml b/b2g/config/nexus-5-l/sources.xml
index e7319942e2d0..0419408a3e85 100644
--- a/b2g/config/nexus-5-l/sources.xml
+++ b/b2g/config/nexus-5-l/sources.xml
@@ -8,7 +8,7 @@
-
+
@@ -16,7 +16,7 @@
-
+
diff --git a/browser/app/profile/firefox.js b/browser/app/profile/firefox.js
index 0a7d747cc1ca..bf31eb16450b 100644
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -377,12 +377,6 @@ pref("browser.search.context.loadInBackground", false);
// comma seperated list of of engines to hide in the search panel.
pref("browser.search.hiddenOneOffs", "");
-#ifdef XP_WIN
-pref("browser.search.redirectWindowsSearch", true);
-#else
-pref("browser.search.redirectWindowsSearch", false);
-#endif
-
pref("browser.search.reset.enabled", true);
pref("browser.usedOnWindows10", false);
diff --git a/browser/base/content/tabbrowser.xml b/browser/base/content/tabbrowser.xml
index 5feea7b35b32..6fdca43b31ed 100644
--- a/browser/base/content/tabbrowser.xml
+++ b/browser/base/content/tabbrowser.xml
@@ -2417,12 +2417,12 @@
// processes the event queue and may lead to another removeTab()
// call before permitUnload() returns.
aTab._pendingPermitUnload = true;
- let {permitUnload} = browser.permitUnload();
+ let {permitUnload, timedOut} = browser.permitUnload();
delete aTab._pendingPermitUnload;
// If we were closed during onbeforeunload, we return false now
// so we don't (try to) close the same tab again. Of course, we
// also stop if the unload was cancelled by the user:
- if (aTab.closing || !permitUnload) {
+ if (aTab.closing || (!timedOut && !permitUnload)) {
// NB: deliberately keep the _closedDuringPermitUnload set to
// true so we keep exiting early in case of multiple calls.
return false;
diff --git a/browser/base/content/test/general/browser_misused_characters_in_strings.js b/browser/base/content/test/general/browser_misused_characters_in_strings.js
index 9b3c598ffaf9..d4ca1c85694e 100644
--- a/browser/base/content/test/general/browser_misused_characters_in_strings.js
+++ b/browser/base/content/test/general/browser_misused_characters_in_strings.js
@@ -100,6 +100,14 @@ let gWhitelist = [{
file: "netErrorApp.dtd",
key: "securityOverride.warningContent",
type: "single-quote"
+ }, {
+ file: "pocket.properties",
+ key: "tos",
+ type: "double-quote"
+ }, {
+ file: "pocket.properties",
+ key: "tos",
+ type: "apostrophe"
}
];
diff --git a/browser/base/content/test/urlbar/browser_autocomplete_autoselect.js b/browser/base/content/test/urlbar/browser_autocomplete_autoselect.js
index 9852e8395cea..e96f54351369 100644
--- a/browser/base/content/test/urlbar/browser_autocomplete_autoselect.js
+++ b/browser/base/content/test/urlbar/browser_autocomplete_autoselect.js
@@ -1,3 +1,5 @@
+const ONEOFF_URLBAR_PREF = "browser.urlbar.oneOffSearches";
+
function repeat(limit, func) {
for (let i = 0; i < limit; i++) {
func(i);
@@ -26,8 +28,10 @@ function is_selected_one_off(index) {
add_task(function*() {
let maxResults = Services.prefs.getIntPref("browser.urlbar.maxRichResults");
+ Services.prefs.setBoolPref(ONEOFF_URLBAR_PREF, true);
registerCleanupFunction(function* () {
yield PlacesTestUtils.clearHistory();
+ Services.prefs.clearUserPref(ONEOFF_URLBAR_PREF);
});
let visits = [];
diff --git a/browser/components/nsBrowserContentHandler.js b/browser/components/nsBrowserContentHandler.js
index a456f9c407a3..3ed2ac99ed79 100644
--- a/browser/components/nsBrowserContentHandler.js
+++ b/browser/components/nsBrowserContentHandler.js
@@ -2,8 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-Components.utils.importGlobalProperties(["URLSearchParams"]);
-
Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
Components.utils.import("resource://gre/modules/Services.jsm");
Components.utils.import("resource://gre/modules/AppConstants.jsm");
@@ -744,60 +742,10 @@ nsDefaultCommandLineHandler.prototype = {
}
}
- let redirectWinSearch = false;
- if (AppConstants.isPlatformAndVersionAtLeast("win", "10")) {
- redirectWinSearch = Services.prefs.getBoolPref("browser.search.redirectWindowsSearch");
- }
-
try {
var ar;
while ((ar = cmdLine.handleFlagWithParam("url", false))) {
var uri = resolveURIInternal(cmdLine, ar);
-
- // Searches in the Windows 10 task bar searchbox simply open the default browser
- // with a URL for a search on Bing. Here we extract the search term and use the
- // user's default search engine instead.
- var uriScheme = "", uriHost = "", uriPath = "";
- try {
- uriScheme = uri.scheme;
- uriHost = uri.host;
- uriPath = uri.path;
- } catch (e) {
- }
-
- // Most Windows searches are "https://www.bing.com/search...", but bug
- // 1182308 reports a Chinese edition of Windows 10 using
- // "http://cn.bing.com/search...", so be a bit flexible in what we match.
- if (redirectWinSearch &&
- (uriScheme == "http" || uriScheme == "https") &&
- uriHost.endsWith(".bing.com") && uriPath.startsWith("/search")) {
- try {
- var url = uri.QueryInterface(Components.interfaces.nsIURL);
- var params = new URLSearchParams(url.query);
- // We don't want to rewrite all Bing URLs coming from external apps. Look
- // for the magic URL parm that's present in searches from the task bar.
- // * Typed searches use "form=WNSGPH"
- // * Cortana voice searches use "FORM=WNSBOX" or direct results, or "FORM=WNSFC2"
- // for "see more results on Bing.com")
- // * Cortana voice searches started from "Hey, Cortana" use "form=WNSHCO"
- // or "form=WNSSSV" or "form=WNSSCX"
- var allowedParams = ["WNSGPH", "WNSBOX", "WNSFC2", "WNSHCO", "WNSSCX", "WNSSSV"];
- var formParam = params.get("form");
- if (!formParam) {
- formParam = params.get("FORM");
- }
- if (allowedParams.indexOf(formParam) != -1) {
- var term = params.get("q");
- var engine = Services.search.defaultEngine;
- logSystemBasedSearch(engine);
- var submission = engine.getSubmission(term, null, "system");
- uri = submission.uri;
- }
- } catch (e) {
- Components.utils.reportError("Couldn't redirect Windows search: " + e);
- }
- }
-
urilist.push(uri);
}
}
diff --git a/browser/components/preferences/in-content/search.js b/browser/components/preferences/in-content/search.js
index be34eb8595e6..eb840081fd65 100644
--- a/browser/components/preferences/in-content/search.js
+++ b/browser/components/preferences/in-content/search.js
@@ -3,8 +3,6 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
-XPCOMUtils.defineLazyModuleGetter(this, "AppConstants",
- "resource://gre/modules/AppConstants.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "PlacesUtils",
"resource://gre/modules/PlacesUtils.jsm");
XPCOMUtils.defineLazyModuleGetter(this, "Task",
@@ -12,12 +10,6 @@ XPCOMUtils.defineLazyModuleGetter(this, "Task",
const ENGINE_FLAVOR = "text/x-moz-search-engine";
-document.addEventListener("Initialized", () => {
- if (!AppConstants.isPlatformAndVersionAtLeast("win", "10")) {
- document.getElementById("redirectSearchCheckbox").hidden = true;
- }
-});
-
var gEngineView = null;
var gSearchPane = {
diff --git a/browser/components/preferences/in-content/search.xul b/browser/components/preferences/in-content/search.xul
index c01717de8d39..95c7acd85deb 100644
--- a/browser/components/preferences/in-content/search.xul
+++ b/browser/components/preferences/in-content/search.xul
@@ -12,10 +12,6 @@
name="browser.search.hiddenOneOffs"
type="unichar"/>
-
-
+
+
+
+