Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 00:35:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1605143 - Part 2: Fold JSOp::SuperFun to ensure inlined class constructors use MCreateThisWithProto. r=jandem

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D58804

--HG--
extra : moz-landing-system : lando
This commit is contained in:
André Bargull 2020-02-18 15:56:33 +00:00
parent d46cd57c1f
commit 2397c625f5
1 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
js/src/jit/IonBuilder.cpp
View File

@ -12858,7 +12858,40 @@ AbortReasonOr<Ok> IonBuilder::jsop_checkreturn() {
}
AbortReasonOr<Ok> IonBuilder::jsop_superfun() {
auto* ins = MSuperFunction::New(alloc(), current->pop());
MDefinition* callee = current->pop();
do {
TemporaryTypeSet* calleeTypes = callee->resultTypeSet();
JSObject* calleeObj = calleeTypes ? calleeTypes->maybeSingleton() : nullptr;
if (!calleeObj) {
break;
}
// Refuse to optimize if the prototype is uncacheable.
if (calleeObj->hasUncacheableProto() || !calleeObj->hasStaticPrototype()) {
break;
}
// The prototype must be a constructor.
JSObject* proto = calleeObj->staticPrototype();
if (!proto || !proto->isConstructor()) {
break;
}
// Add a constraint to ensure we're notified when the prototype changes.
TypeSet::ObjectKey* calleeKey = TypeSet::ObjectKey::get(calleeObj);
if (!calleeKey->hasStableClassAndProto(constraints())) {
break;
}
callee->setImplicitlyUsedUnchecked();
pushConstant(ObjectValue(*proto));
return Ok();
} while (false);
auto* ins = MSuperFunction::New(alloc(), callee);
current->add(ins);
current->push(ins);
return Ok();