Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 21:01:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1913114 - wasm: Rename tiering aggressiveness pref and use it in our tests. r=yury

Browse Source 
Remove the experimental prefix from our tiering level, and use the max in our tests
to ensure we have coverage of tier-ups.

Differential Revision: https://phabricator.services.mozilla.com/D225125
This commit is contained in:
Ryan Hunt 2024-10-14 15:41:35 +00:00
parent f98aa22df0
commit 2423d47f14
8 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/src/jit-test/tests/wasm/bench/directives.txt
View File

@ -1 +1 @@
|jit-test| test-also=--wasm-compiler=optimizing; test-also=--wasm-compiler=baseline; test-also=--test-wasm-await-tier2; test-also=-P wasm_lazy_tiering; test-also=--disable-wasm-huge-memory; skip-variant-if: --disable-wasm-huge-memory, !wasmHugeMemorySupported(); include:wasm.js
|jit-test| test-also=--wasm-compiler=optimizing; test-also=--wasm-compiler=baseline; test-also=--test-wasm-await-tier2; test-also=-P wasm_lazy_tiering -P wasm_lazy_tiering_level=9; test-also=--disable-wasm-huge-memory; skip-variant-if: --disable-wasm-huge-memory, !wasmHugeMemorySupported(); include:wasm.js

2
js/src/jit-test/tests/wasm/directives.txt
View File

@ -1 +1 @@
|jit-test| test-also=--wasm-compiler=optimizing; test-also=--wasm-compiler=baseline; test-also=--test-wasm-await-tier2; test-also=-P wasm_lazy_tiering; test-also=--disable-wasm-huge-memory; skip-variant-if: --disable-wasm-huge-memory, !wasmHugeMemorySupported(); test-also=--setpref=wasm_test_serialization=true; test-also=--wasm-compiler=optimizing --no-avx; skip-variant-if: --wasm-compiler=optimizing --no-avx, !getBuildConfiguration("x86") && !getBuildConfiguration("x64") || getBuildConfiguration("simulator"); include:wasm.js
|jit-test| test-also=--wasm-compiler=optimizing; test-also=--wasm-compiler=baseline; test-also=--test-wasm-await-tier2; test-also=-P wasm_lazy_tiering -P wasm_lazy_tiering_level=9; test-also=--disable-wasm-huge-memory; skip-variant-if: --disable-wasm-huge-memory, !wasmHugeMemorySupported(); test-also=--setpref=wasm_test_serialization=true; test-also=--wasm-compiler=optimizing --no-avx; skip-variant-if: --wasm-compiler=optimizing --no-avx, !getBuildConfiguration("x86") && !getBuildConfiguration("x64") || getBuildConfiguration("simulator"); include:wasm.js

2
js/src/jit-test/tests/wasm/gc/speculative-inlining.js
View File

@ -1,4 +1,4 @@
// |jit-test| skip-if: !wasmGcEnabled() || !wasmExperimentalCompilePipelineEnabled(); test-also=-P wasm_lazy_tiering;
// |jit-test| skip-if: !wasmGcEnabled() || !wasmExperimentalCompilePipelineEnabled(); test-also=-P wasm_lazy_tiering -P wasm_lazy_tiering_level=9;
// Needs to be at least 13500 in order for test functions to tier up.
// See Instance::computeInitialHotnessCounter.

2
js/src/jit-test/tests/wasm/lazy-tiering-codegen.js
View File

@ -1,4 +1,4 @@
// |jit-test| skip-if: !wasmExperimentalCompilePipelineEnabled() || !getBuildConfiguration("x64") || !hasDisassembler() || getBuildConfiguration("simulator"); test-also=-P wasm_lazy_tiering; include:codegen-x64-test.js
// |jit-test| skip-if: !wasmExperimentalCompilePipelineEnabled() || !getBuildConfiguration("x64") || !hasDisassembler() || getBuildConfiguration("simulator"); test-also=-P wasm_lazy_tiering -P wasm_lazy_tiering_level=9; include:codegen-x64-test.js
assertEq(hasDisassembler(), true);

2
js/src/jit-test/tests/wasm/regress/bug1913876.js
View File

@ -1,4 +1,4 @@
// |jit-test| skip-if: !wasmGcEnabled(); test-also=-P wasm_lazy_tiering;
// |jit-test| skip-if: !wasmGcEnabled(); test-also=-P wasm_lazy_tiering -P wasm_lazy_tiering_level=9;
let {a} = wasmEvalText(`(module
(type $t (func))

2
js/src/jit-test/tests/wasm/regress/directives.txt
View File

@ -1 +1 @@
|jit-test| test-also=--wasm-compiler=optimizing; test-also=--wasm-compiler=baseline; test-also=--test-wasm-await-tier2; test-also=-P wasm_lazy_tiering; test-also=--disable-wasm-huge-memory; skip-variant-if: --disable-wasm-huge-memory, !wasmHugeMemorySupported(); include:wasm.js
|jit-test| test-also=--wasm-compiler=optimizing; test-also=--wasm-compiler=baseline; test-also=--test-wasm-await-tier2; test-also=-P wasm_lazy_tiering -P wasm_lazy_tiering_level=9; test-also=--disable-wasm-huge-memory; skip-variant-if: --disable-wasm-huge-memory, !wasmHugeMemorySupported(); include:wasm.js

2
js/src/wasm/WasmHeuristics.h
View File

@ -53,7 +53,7 @@ class LazyTieringHeuristics {
public:
LazyTieringHeuristics() {
level_ = JS::Prefs::wasm_experimental_tiering_level();
level_ = JS::Prefs::wasm_lazy_tiering_level();
// Clamp to range MIN_LEVEL .. MAX_LEVEL.
level_ = std::max<uint32_t>(level_, MIN_LEVEL);
level_ = std::min<uint32_t>(level_, MAX_LEVEL);

2
modules/libpref/init/StaticPrefList.yaml
View File

@ -8393,7 +8393,7 @@
# Aggressiveness of lazy tiering, allowable: 1 .. 9
# 1 = min (almost never, set tiering threshold to max possible, == 2^31-1)
# 9 = max (request tier up at first call, set tiering threshold to zero)
- name: javascript.options.wasm_experimental_tiering_level
- name: javascript.options.wasm_lazy_tiering_level
type: uint32_t
value: 5
mirror: always