Bug 1605370 - Rewrite ok(message) as ok(true, message) in DevTools tests r=daisuke

Differential Revision: https://phabricator.services.mozilla.com/D57972

--HG--
extra : moz-landing-system : lando

devtools/client/application/test/browser/browser_application_panel_manifest-display.js

@@ -19,7 +19,7 @@ add_task(async function() {
 
   info("Waiting for the manifest to be displayed");
   await waitUntil(() => doc.querySelector(".js-manifest") !== null);
-  ok("Manifest is being displayed");
+  ok(true, "Manifest is being displayed");
 
   // assert manifest members are being properly displayed
   checkManifestMember(doc, "name", "Foo");
@@ -49,7 +49,7 @@ add_task(async function() {
 
   info("Waiting for the manifest to be displayed");
   await waitUntil(() => doc.querySelector(".js-manifest") !== null);
-  ok("Manifest is being displayed");
+  ok(true, "Manifest is being displayed");
 
   // assert manifest members are being properly displayed
   checkManifestMember(doc, "name", "Foo");
@@ -80,7 +80,7 @@ add_task(async function() {
 
   info("Waiting for the manifest to be displayed");
   await waitUntil(() => doc.querySelector(".js-manifest") !== null);
-  ok("Manifest is being displayed");
+  ok(true, "Manifest is being displayed");
 
   const issuesEl = doc.querySelector(".js-manifest-issues");
   ok(issuesEl !== null, "Validation issues are displayed");

devtools/client/debugger/test/mochitest/browser_dbg-bfcache.js

@@ -12,5 +12,5 @@ add_task(async function() {
   await waitForSources(dbg, "doc-bfcache1.html");
   invokeInTab("goForward");
   await waitForSources(dbg, "doc-bfcache2.html");
-  ok("Found sources after BFCache navigations");
+  ok(true, "Found sources after BFCache navigations");
 });

devtools/client/debugger/test/mochitest/browser_dbg-breakpoint-skipping-console.js

@@ -14,5 +14,5 @@ add_task(async function() {
   toolbox.target.navigateTo({ url: "doc-debugger-statements.html" });
 
   await hasConsoleMessage({ toolbox }, 'done!')
-  ok('We reached the end');
+  ok(true, 'We reached the end');
 });

devtools/client/debugger/test/mochitest/browser_dbg-breakpoints-actions.js

@@ -19,7 +19,7 @@ add_task(async function() {
   selectContextMenuItem(dbg, selectors.breakpointContextMenu.remove);
 
   await waitForState(dbg, state => dbg.selectors.getBreakpointCount() === 0);
-  ok("successfully removed the breakpoint");
+  ok(true, "successfully removed the breakpoint");
 });
 
 // Tests "disable others", "enable others" and "remove others" context actions
@@ -47,7 +47,7 @@ add_task(async function() {
       .every(bp => (bp.location.line !== 4) === bp.disabled)
   );
   await dispatched;
-  ok("breakpoint at 4 is the only enabled breakpoint");
+  ok(true, "breakpoint at 4 is the only enabled breakpoint");
 
   openFirstBreakpointContextMenu(dbg);
   // select "Disable All"
@@ -57,7 +57,7 @@ add_task(async function() {
     dbg.selectors.getBreakpointsList().every(bp => bp.disabled)
   );
   await dispatched;
-  ok("all breakpoints are disabled");
+  ok(true, "all breakpoints are disabled");
 
   openFirstBreakpointContextMenu(dbg);
   // select "Enable Others"
@@ -69,7 +69,7 @@ add_task(async function() {
       .every(bp => (bp.location.line === 4) === bp.disabled)
   );
   await dispatched;
-  ok("all breakpoints except line 1 are enabled");
+  ok(true, "all breakpoints except line 1 are enabled");
 
   openFirstBreakpointContextMenu(dbg);
   // select "Remove Others"
@@ -82,5 +82,5 @@ add_task(async function() {
       dbg.selectors.getBreakpointsList()[0].location.line === 4
   );
   await dispatched;
-  ok("remaining breakpoint should be on line 4");
+  ok(true, "remaining breakpoint should be on line 4");
 });

devtools/client/debugger/test/mochitest/browser_dbg-remember-expanded-scopes.js

@@ -37,5 +37,5 @@ add_task(async function() {
   await waitForPaused(dbg);
 
   await waitUntil(() => findNode(dbg, "innerData"));
-  ok("Inner object data automatically expanded after stepping");
+  ok(true, "Inner object data automatically expanded after stepping");
 });

devtools/client/inspector/test/browser_inspector_initialization.js

@@ -57,7 +57,7 @@ async function testToolboxInitialization(testActor, tab) {
   info("Destroying toolbox");
   await toolbox.destroy();
 
-  ok("true", "'destroyed' notification received.");
+  ok(true, "'destroyed' notification received.");
   ok(!gDevTools.getToolbox(target), "Toolbox destroyed.");
 }
 

devtools/client/inspector/test/browser_inspector_reload_xul.js

@@ -41,7 +41,7 @@ async function testToolboxInitialization(tab, inspector, toolbox) {
   info("Destroying toolbox.");
   await toolbox.destroy();
 
-  ok("true", "'destroyed' notification received.");
+  ok(true, "'destroyed' notification received.");
   ok(!gDevTools.getToolbox(target), "Toolbox destroyed.");
 }
 

devtools/client/performance/test/browser_perf-refresh.js

@@ -40,7 +40,7 @@ add_task(async function() {
   );
 
   await waitUntil(() => recording.getMarkers().length > markersLength);
-  ok("Markers continue after reload.");
+  ok(true, "Markers continue after reload.");
 
   await stopRecording(panel);
   await teardownToolboxAndRemoveTab(panel);

devtools/client/webconsole/test/browser/browser_jsterm_editor.js

@@ -41,7 +41,7 @@ add_task(async function() {
   await toggleLayout(hud);
   getInlineOpenEditorButton(hud).click();
   await waitFor(() => isEditorModeEnabled(hud));
-  ok("Editor is open when clicking on the button");
+  ok(true, "Editor is open when clicking on the button");
 });
 
 function getInlineOpenEditorButton(hud) {

devtools/client/webconsole/test/browser/browser_webconsole_observer_notifications.js

@@ -18,7 +18,7 @@ add_task(async function() {
   await closeTabAndToolbox(gBrowser.selectedTab);
   await waitFor(() => destroyed);
 
-  ok("We received both created and destroyed events");
+  ok(true, "We received both created and destroyed events");
 });
 
 function setupObserver() {