Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 17:25:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1386384 - Update DevTools CSS stubs for Stylo. r=bgrins

Browse Source 
Two specific changes have occurred with Stylo:

* `lineText` is no longer set because it caused performance regressions to
  compute it and it is currently unused by DevTools.
* `columnNumber` is computed differently with Stylo.  It's currently the
  beginning of property, instead of the end.  Bug 1378861 is filed for future
  improvements to this info.

MozReview-Commit-ID: 5vTdjNbuhXe

--HG--
extra : rebase_source : 402f957c431f47234ab83acbf3375d66ecabaf16
This commit is contained in:
J. Ryan Stinnett 2017-09-06 12:34:57 -05:00
parent 44e1e9ebce
commit 24b188626d
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/browser.ini vendored
View File

@ -11,7 +11,7 @@ support-files =
[browser_webconsole_check_stubs_console_api.js]
[browser_webconsole_check_stubs_css_message.js]
skip-if = stylo # Bug 1386384 - Regenerate fixtures once Stylo is default
skip-if = !stylo # Stubs updated for Stylo, won't match old Gecko style system
[browser_webconsole_check_stubs_evaluation_result.js]
[browser_webconsole_check_stubs_network_event.js]
[browser_webconsole_check_stubs_page_error.js]

16
devtools/client/webconsole/new-console-output/test/fixtures/stubs/cssMessage.js vendored
View File

@ -23,12 +23,12 @@ stubPreparedMessages.set("Unknown property ‘such-unknown-property’. Declara
"level": "warn",
"messageText": "Unknown property ‘such-unknown-property’. Declaration dropped.",
"parameters": null,
"repeatId": "{\"frame\":{\"source\":\"http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-css-message.html\",\"line\":3,\"column\":23},\"groupId\":null,\"indent\":0,\"level\":\"warn\",\"messageText\":\"Unknown property ‘such-unknown-property’. Declaration dropped.\",\"parameters\":null,\"source\":\"css\",\"type\":\"log\",\"userProvidedStyles\":null}",
"repeatId": "{\"frame\":{\"source\":\"http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-css-message.html\",\"line\":3,\"column\":2},\"groupId\":null,\"indent\":0,\"level\":\"warn\",\"messageText\":\"Unknown property ‘such-unknown-property’. Declaration dropped.\",\"parameters\":null,\"source\":\"css\",\"type\":\"log\",\"userProvidedStyles\":null}",
"stacktrace": null,
"frame": {
"source": "http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-css-message.html",
"line": 3,
"column": 23
"column": 2
},
"groupId": null,
"userProvidedStyles": null,
@ -46,12 +46,12 @@ stubPreparedMessages.set("Error in parsing value for ‘padding-top’. Declara
"level": "warn",
"messageText": "Error in parsing value for ‘padding-top’. Declaration dropped.",
"parameters": null,
"repeatId": "{\"frame\":{\"source\":\"http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-css-message.html\",\"line\":3,\"column\":15},\"groupId\":null,\"indent\":0,\"level\":\"warn\",\"messageText\":\"Error in parsing value for ‘padding-top’. Declaration dropped.\",\"parameters\":null,\"source\":\"css\",\"type\":\"log\",\"userProvidedStyles\":null}",
"repeatId": "{\"frame\":{\"source\":\"http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-css-message.html\",\"line\":3,\"column\":2},\"groupId\":null,\"indent\":0,\"level\":\"warn\",\"messageText\":\"Error in parsing value for ‘padding-top’. Declaration dropped.\",\"parameters\":null,\"source\":\"css\",\"type\":\"log\",\"userProvidedStyles\":null}",
"stacktrace": null,
"frame": {
"source": "http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-css-message.html",
"line": 3,
"column": 15
"column": 2
},
"groupId": null,
"userProvidedStyles": null,
@ -66,9 +66,9 @@ stubPackets.set("Unknown property ‘such-unknown-property’. Declaration drop
"errorMessage": "Unknown property ‘such-unknown-property’. Declaration dropped.",
"errorMessageName": "",
"sourceName": "http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-css-message.html",
"lineText": " such-unknown-property: wow;",
"lineText": "",
"lineNumber": 3,
"columnNumber": 23,
"columnNumber": 2,
"category": "CSS Parser",
"timeStamp": 1479159920406,
"warning": true,
@ -89,9 +89,9 @@ stubPackets.set("Error in parsing value for ‘padding-top’. Declaration drop
"errorMessage": "Error in parsing value for ‘padding-top’. Declaration dropped.",
"errorMessageName": "",
"sourceName": "http://example.com/browser/devtools/client/webconsole/new-console-output/test/fixtures/stub-generators/test-css-message.html",
"lineText": " padding-top: invalid value;",
"lineText": "",
"lineNumber": 3,
"columnNumber": 15,
"columnNumber": 2,
"category": "CSS Parser",
"timeStamp": 1479159920465,
"warning": true,