Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-02 03:49:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1519636 - Reformat recent changes to the Google coding style. r=necko-reviewers,geckoview-reviewers,agi

Browse Source 
Updated with clang-format version 11.0.1 (taskcluster-GI8pmG3eQ_OSXfjFfr2yFw)

\# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D113294
This commit is contained in:
Andi-Bogdan Postelnicu 2021-04-26 15:52:25 +00:00
parent 5c9bd32723
commit 2508edc4c5
30 changed files with 71 additions and 95 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dom/base/DocGroup.cpp
View File

@ -44,7 +44,8 @@ class LabellingEventTarget final : public nsISerialEventTarget,
public:
NS_DECLARE_STATIC_IID_ACCESSOR(NS_LABELLINGEVENTTARGET_IID)
explicit LabellingEventTarget(mozilla::PerformanceCounter* aPerformanceCounter)
explicit LabellingEventTarget(
mozilla::PerformanceCounter* aPerformanceCounter)
: mPerformanceCounter(aPerformanceCounter),
mMainThread(
static_cast<nsThread*>(mozilla::GetMainThreadSerialEventTarget())) {

4
dom/base/nsMappedAttributes.h
View File

@ -55,9 +55,7 @@ class nsMappedAttributes final {
auto Attrs() const {
return mozilla::Span<const InternalAttr>{mBuffer, mAttrCount};
}
auto Attrs() {
return mozilla::Span<InternalAttr>{mBuffer, mAttrCount};
}
auto Attrs() { return mozilla::Span<InternalAttr>{mBuffer, mAttrCount}; }
const nsAttrName* NameAt(uint32_t aPos) const {
NS_ASSERTION(aPos < mAttrCount, "out-of-bounds");
return &Attrs()[aPos].mName;

2
dom/canvas/TexUnpackBlob.cpp
View File

@ -577,7 +577,7 @@ bool TexUnpackBytes::TexOrSubImage(bool isSubImage, bool needsRespec,
if (!useParanoidHandling) {
const ScopedLazyBind bindPBO(gl, LOCAL_GL_PIXEL_UNPACK_BUFFER,
webgl->mBoundPixelUnpackBuffer);
webgl->mBoundPixelUnpackBuffer);
*out_error =
DoTexOrSubImage(isSubImage, gl, target, level, dui, xOffset, yOffset,

4
dom/html/HTMLInputElement.h
View File

@ -1582,8 +1582,8 @@ class HTMLInputElement final : public TextControlElement,
static bool MayFireChangeOnBlur(uint8_t aType) {
return IsSingleLineTextControl(false, aType) ||
CreatesDateTimeWidget(aType) ||
aType == NS_FORM_INPUT_RANGE || aType == NS_FORM_INPUT_NUMBER;
CreatesDateTimeWidget(aType) || aType == NS_FORM_INPUT_RANGE ||
aType == NS_FORM_INPUT_NUMBER;
}
/**

26
dom/notification/Notification.cpp
View File

@ -895,13 +895,16 @@ already_AddRefed<Notification> Notification::CreateInternal(
}
nsTArray<uint32_t> vibrate;
if (StaticPrefs::dom_webnotifications_vibrate_enabled() && aOptions.mVibrate.WasPassed()) {
if (StaticPrefs::dom_webnotifications_vibrate_enabled() &&
aOptions.mVibrate.WasPassed()) {
if (silent) {
aRv.ThrowTypeError("Silent notifications must not specify vibration patterns.");
aRv.ThrowTypeError(
"Silent notifications must not specify vibration patterns.");
return nullptr;
}
const OwningUnsignedLongOrUnsignedLongSequence& value = aOptions.mVibrate.Value();
const OwningUnsignedLongOrUnsignedLongSequence& value =
aOptions.mVibrate.Value();
if (value.IsUnsignedLong()) {
AutoTArray<uint32_t, 1> array;
array.AppendElement(value.GetAsUnsignedLong());
@ -911,11 +914,10 @@ already_AddRefed<Notification> Notification::CreateInternal(
}
}
RefPtr<Notification> notification =
new Notification(aGlobal, id, aTitle, aOptions.mBody, aOptions.mDir,
aOptions.mLang, aOptions.mTag, aOptions.mIcon,
aOptions.mRequireInteraction, silent,
std::move(vibrate), aOptions.mMozbehavior);
RefPtr<Notification> notification = new Notification(
aGlobal, id, aTitle, aOptions.mBody, aOptions.mDir, aOptions.mLang,
aOptions.mTag, aOptions.mIcon, aOptions.mRequireInteraction, silent,
std::move(vibrate), aOptions.mMozbehavior);
rv = notification->Init();
NS_ENSURE_SUCCESS(rv, nullptr);
return notification.forget();
@ -1418,10 +1420,10 @@ void Notification::ShowInternal() {
do_CreateInstance(ALERT_NOTIFICATION_CONTRACTID);
NS_ENSURE_TRUE_VOID(alert);
nsIPrincipal* principal = GetPrincipal();
rv = alert->Init(alertName, iconUrl, mTitle, mBody, true, uniqueCookie,
DirectionToString(mDir), mLang, mDataAsBase64,
GetPrincipal(), inPrivateBrowsing, requireInteraction,
mSilent, mVibrate);
rv =
alert->Init(alertName, iconUrl, mTitle, mBody, true, uniqueCookie,
DirectionToString(mDir), mLang, mDataAsBase64, GetPrincipal(),
inPrivateBrowsing, requireInteraction, mSilent, mVibrate);
NS_ENSURE_SUCCESS_VOID(rv);
if (isPersistent) {

3
dom/notification/Notification.h
View File

@ -251,8 +251,7 @@ class Notification : public DOMEventTargetHelper,
static already_AddRefed<Notification> CreateInternal(
nsIGlobalObject* aGlobal, const nsAString& aID, const nsAString& aTitle,
const NotificationOptions& aOptions,
ErrorResult& aRv);
const NotificationOptions& aOptions, ErrorResult& aRv);
nsresult Init();
bool IsInPrivateBrowsing();

4
extensions/spellcheck/src/mozInlineSpellChecker.h
View File

@ -244,8 +244,8 @@ class mozInlineSpellChecker final : public nsIInlineSpellChecker,
// helper routine to determine if a point is inside of the passed in
// selection.
static nsresult IsPointInSelection(mozilla::dom::Selection& aSelection,
nsINode* aNode, int32_t aOffset,
nsRange** aRange);
nsINode* aNode, int32_t aOffset,
nsRange** aRange);
nsresult CleanupRangesInSelection(mozilla::dom::Selection* aSelection);

3
gfx/layers/SurfacePoolCA.mm
View File

@ -165,8 +165,7 @@ CFTypeRefPtr<IOSurfaceRef> SurfacePoolCA::LockedPool::ObtainSurfaceFromPool(cons
}));
if (surface) {
if (StaticPrefs::gfx_color_management_native_srgb()) {
IOSurfaceSetValue(surface.get(), CFSTR("IOSurfaceColorSpace"),
kCGColorSpaceSRGB);
IOSurfaceSetValue(surface.get(), CFSTR("IOSurfaceColorSpace"), kCGColorSpaceSRGB);
}
// Create a new entry in mInUseEntries.
MutateEntryStorage("Create", aSize, [&]() {

3
gfx/src/nsITheme.h
View File

@ -83,8 +83,7 @@ class nsITheme : public nsISupports {
enum class DrawOverflow { No, Yes };
NS_IMETHOD DrawWidgetBackground(gfxContext* aContext, nsIFrame* aFrame,
StyleAppearance aWidgetType,
const nsRect& aRect,
const nsRect& aDirtyRect,
const nsRect& aRect, const nsRect& aDirtyRect,
DrawOverflow = DrawOverflow::Yes) = 0;
/**

2
js/src/wasm/WasmJS.h
View File

@ -34,7 +34,7 @@
#include "js/RootingAPI.h" // MovableCellHasher
#include "js/SweepingAPI.h" // JS::WeakCache
#include "js/TypeDecls.h" // HandleValue, HandleObject, MutableHandleObject, MutableHandleFunction
#include "js/Vector.h" // JS::Vector
#include "js/Vector.h" // JS::Vector
#include "js/WasmFeatures.h"
#include "vm/JSFunction.h" // JSFunction
#include "vm/NativeObject.h" // NativeObject

3
mozglue/android/APKOpen.cpp
View File

@ -385,7 +385,8 @@ Java_org_mozilla_gecko_mozglue_GeckoLoader_nativeRun(
MOZ_ASSERT(outFilePath);
outFilePathRaw = jenv->GetStringUTFChars(outFilePath, nullptr);
}
gBootstrap->GeckoStart(jenv, argv, argc, sAppData, xpcshell, outFilePathRaw);
gBootstrap->GeckoStart(jenv, argv, argc, sAppData, xpcshell,
outFilePathRaw);
if (outFilePathRaw) {
jenv->ReleaseStringUTFChars(outFilePath, outFilePathRaw);
}

9
netwerk/protocol/http/nsHttpChannel.cpp
View File

@ -704,10 +704,7 @@ nsresult nsHttpChannel::ContinueOnBeforeConnect(bool aShouldUpgrade,
// notify "http-on-before-connect" observers
gHttpHandler->OnBeforeConnect(this);
return CallOrWaitForResume(
[](auto* self) {
return self->Connect();
});
return CallOrWaitForResume([](auto* self) { return self->Connect(); });
}
nsresult nsHttpChannel::Connect() {
@ -6708,9 +6705,7 @@ nsresult nsHttpChannel::BeginConnect() {
}
rv = CallOrWaitForResume(
[](nsHttpChannel* self) {
return self->PrepareToConnect();
});
[](nsHttpChannel* self) { return self->PrepareToConnect(); });
if (NS_FAILED(rv)) {
return rv;
}

3
netwerk/system/android/nsAndroidNetworkLinkService.cpp
View File

@ -153,7 +153,8 @@ nsAndroidNetworkLinkService::GetDnsSuffixList(
}
NS_IMETHODIMP
nsAndroidNetworkLinkService::GetResolvers(nsTArray<RefPtr<nsINetAddr>>& aResolvers) {
nsAndroidNetworkLinkService::GetResolvers(
nsTArray<RefPtr<nsINetAddr>>& aResolvers) {
return NS_ERROR_NOT_IMPLEMENTED;
}

3
netwerk/system/mac/nsNetworkLinkService.mm
View File

@ -174,8 +174,7 @@ nsNetworkLinkService::GetResolvers(nsTArray<RefPtr<nsINetAddr>>& aResolvers) {
}
NS_IMETHODIMP
nsNetworkLinkService::GetNativeResolvers(
nsTArray<mozilla::net::NetAddr>& aResolvers) {
nsNetworkLinkService::GetNativeResolvers(nsTArray<mozilla::net::NetAddr>& aResolvers) {
return NS_ERROR_NOT_IMPLEMENTED;
}

13
toolkit/components/alerts/AlertNotificationIPCSerializer.h
View File

@ -48,10 +48,8 @@ struct IPDLParamTraits<nsIAlertNotification*> {
NS_FAILED(aParam->GetInPrivateBrowsing(&inPrivateBrowsing))) ||
NS_WARN_IF(
NS_FAILED(aParam->GetRequireInteraction(&requireInteraction))) ||
NS_WARN_IF(
NS_FAILED(aParam->GetSilent(&silent))) ||
NS_WARN_IF(
NS_FAILED(aParam->GetVibrate(vibrate)))) {
NS_WARN_IF(NS_FAILED(aParam->GetSilent(&silent))) ||
NS_WARN_IF(NS_FAILED(aParam->GetVibrate(vibrate)))) {
// Write a `null` object if any getter returns an error. Otherwise, the
// receiver will try to deserialize an incomplete object and crash.
WriteIPDLParam(aMsg, aActor, /* isNull */ true);
@ -112,10 +110,9 @@ struct IPDLParamTraits<nsIAlertNotification*> {
*aResult = nullptr;
return true;
}
nsresult rv = alert->Init(name, imageURL, title, text, textClickable,
cookie, dir, lang, data, principal,
inPrivateBrowsing, requireInteraction,
silent, vibrate);
nsresult rv = alert->Init(
name, imageURL, title, text, textClickable, cookie, dir, lang, data,
principal, inPrivateBrowsing, requireInteraction, silent, vibrate);
if (NS_WARN_IF(NS_FAILED(rv))) {
*aResult = nullptr;
return true;

9
toolkit/components/alerts/nsAlertsService.cpp
View File

@ -187,11 +187,10 @@ NS_IMETHODIMP nsAlertsService::ShowAlertNotification(
NS_ENSURE_TRUE(alert, NS_ERROR_FAILURE);
// vibrate is unused
nsTArray<uint32_t> vibrate;
nsresult rv =
alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText,
aAlertTextClickable, aAlertCookie, aBidi, aLang, aData,
aPrincipal, aInPrivateBrowsing, aRequireInteraction,
false, vibrate);
nsresult rv = alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText,
aAlertTextClickable, aAlertCookie, aBidi, aLang,
aData, aPrincipal, aInPrivateBrowsing,
aRequireInteraction, false, vibrate);
NS_ENSURE_SUCCESS(rv, rv);
return ShowAlert(alert, aAlertListener);
}

9
toolkit/components/alerts/nsXULAlerts.cpp
View File

@ -103,11 +103,10 @@ nsXULAlerts::ShowAlertNotification(
NS_ENSURE_TRUE(alert, NS_ERROR_FAILURE);
// vibrate is unused for now
nsTArray<uint32_t> vibrate;
nsresult rv =
alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText,
aAlertTextClickable, aAlertCookie, aBidi, aLang, aData,
aPrincipal, aInPrivateBrowsing, aRequireInteraction,
false, vibrate);
nsresult rv = alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText,
aAlertTextClickable, aAlertCookie, aBidi, aLang,
aData, aPrincipal, aInPrivateBrowsing,
aRequireInteraction, false, vibrate);
NS_ENSURE_SUCCESS(rv, rv);
return ShowAlert(alert, aAlertListener);
}

9
toolkit/system/gnome/nsSystemAlertsService.cpp
View File

@ -35,11 +35,10 @@ NS_IMETHODIMP nsSystemAlertsService::ShowAlertNotification(
NS_ENSURE_TRUE(alert, NS_ERROR_FAILURE);
// vibrate is unused for now
nsTArray<uint32_t> vibrate;
nsresult rv =
alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText,
aAlertTextClickable, aAlertCookie, aBidi, aLang, aData,
aPrincipal, aInPrivateBrowsing, aRequireInteraction,
false, vibrate);
nsresult rv = alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText,
aAlertTextClickable, aAlertCookie, aBidi, aLang,
aData, aPrincipal, aInPrivateBrowsing,
aRequireInteraction, false, vibrate);
NS_ENSURE_SUCCESS(rv, rv);
return ShowAlert(alert, aAlertListener);
}

4
toolkit/xre/Bootstrap.cpp
View File

@ -73,8 +73,8 @@ class BootstrapImpl final : public Bootstrap {
#ifdef MOZ_WIDGET_ANDROID
virtual void GeckoStart(JNIEnv* aEnv, char** argv, int argc,
const StaticXREAppData& aAppData,
bool xpcshell, const char* outFilePath) override {
const StaticXREAppData& aAppData, bool xpcshell,
const char* outFilePath) override {
::GeckoStart(aEnv, argv, argc, aAppData, xpcshell, outFilePath);
}

6
widget/GfxInfoX11.cpp
View File

@ -732,8 +732,7 @@ const nsTArray<GfxDriverInfo>& GfxInfo::GetGfxDriverInfo() {
DesktopEnvironment::All, WindowProtocol::All, DriverVendor::MesaAll,
DeviceFamily::IntelRolloutWebRender, nsIGfxInfo::FEATURE_WEBRENDER,
nsIGfxInfo::FEATURE_ALLOW_ALWAYS, DRIVER_GREATER_THAN_OR_EQUAL,
V(17, 0, 0, 0), "FEATURE_ROLLOUT_INTEL_MESA",
"Mesa 17.0.0.0");
V(17, 0, 0, 0), "FEATURE_ROLLOUT_INTEL_MESA", "Mesa 17.0.0.0");
// Nvidia Mesa baseline, see bug 1563859.
APPEND_TO_DRIVER_BLOCKLIST_EXT(
@ -741,8 +740,7 @@ const nsTArray<GfxDriverInfo>& GfxInfo::GetGfxDriverInfo() {
DesktopEnvironment::All, WindowProtocol::All, DriverVendor::MesaAll,
DeviceFamily::NvidiaRolloutWebRender, nsIGfxInfo::FEATURE_WEBRENDER,
nsIGfxInfo::FEATURE_ALLOW_QUALIFIED, DRIVER_GREATER_THAN_OR_EQUAL,
V(18, 2, 0, 0), "FEATURE_ROLLOUT_NVIDIA_MESA",
"Mesa 18.2.0.0");
V(18, 2, 0, 0), "FEATURE_ROLLOUT_NVIDIA_MESA", "Mesa 18.2.0.0");
// Nvidia proprietary driver baseline, see bug 1673752.
APPEND_TO_DRIVER_BLOCKLIST_EXT(

2
widget/android/nsLookAndFeel.h
View File

@ -23,8 +23,8 @@ class nsLookAndFeel final : public nsXPLookAndFeel {
virtual bool GetEchoPasswordImpl() override;
virtual uint32_t GetPasswordMaskDelayImpl() override;
virtual char16_t GetPasswordCharacterImpl() override;
protected:
protected:
bool mInitializedSystemColors = false;
mozilla::AndroidSystemColors mSystemColors;
bool mInitializedShowPassword = false;

9
widget/android/nsNativeThemeAndroid.cpp
View File

@ -475,12 +475,9 @@ static void PaintRangeThumb(DrawTarget* aDrawTarget, const Rect& aRect,
}
NS_IMETHODIMP
nsNativeThemeAndroid::DrawWidgetBackground(gfxContext* aContext,
nsIFrame* aFrame,
StyleAppearance aAppearance,
const nsRect& aRect,
const nsRect& /* aDirtyRect */,
DrawOverflow) {
nsNativeThemeAndroid::DrawWidgetBackground(
gfxContext* aContext, nsIFrame* aFrame, StyleAppearance aAppearance,
const nsRect& aRect, const nsRect& /* aDirtyRect */, DrawOverflow) {
DrawTarget* dt = aContext->GetDrawTarget();
const nscoord twipsPerPixel = aFrame->PresContext()->AppUnitsPerDevPixel();
EventStates eventState = GetContentState(aFrame, aAppearance);

3
widget/android/nsNativeThemeAndroid.h
View File

@ -19,8 +19,7 @@ class nsNativeThemeAndroid : private nsNativeTheme, public nsITheme {
// The nsITheme interface.
NS_IMETHOD DrawWidgetBackground(gfxContext* aContext, nsIFrame* aFrame,
StyleAppearance aAppearance,
const nsRect& aRect,
const nsRect& aDirtyRect,
const nsRect& aRect, const nsRect& aDirtyRect,
DrawOverflow) override;
/*bool CreateWebRenderCommandsForWidget(mozilla::wr::DisplayListBuilder&
aBuilder, mozilla::wr::IpcResourceUpdateQueue& aResources, const

7
widget/cocoa/OSXNotificationCenter.mm
View File

@ -205,10 +205,9 @@ OSXNotificationCenter::ShowAlertNotification(
NS_ENSURE_TRUE(alert, NS_ERROR_FAILURE);
// vibrate is unused for now
nsTArray<uint32_t> vibrate;
nsresult rv =
alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText, aAlertTextClickable, aAlertCookie,
aBidi, aLang, aData, aPrincipal, aInPrivateBrowsing, aRequireInteraction,
false, vibrate);
nsresult rv = alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText, aAlertTextClickable,
aAlertCookie, aBidi, aLang, aData, aPrincipal, aInPrivateBrowsing,
aRequireInteraction, false, vibrate);
NS_ENSURE_SUCCESS(rv, rv);
return ShowAlert(alert, aAlertListener);
}

3
widget/gtk/nsNativeThemeGTK.h
View File

@ -27,8 +27,7 @@ class nsNativeThemeGTK final : private nsNativeTheme,
// The nsITheme interface.
NS_IMETHOD DrawWidgetBackground(gfxContext* aContext, nsIFrame* aFrame,
StyleAppearance aAppearance,
const nsRect& aRect,
const nsRect& aDirtyRect,
const nsRect& aRect, const nsRect& aDirtyRect,
DrawOverflow) override;
bool CreateWebRenderCommandsForWidget(

3
widget/headless/HeadlessThemeGTK.cpp
View File

@ -18,8 +18,7 @@ NS_IMETHODIMP
HeadlessThemeGTK::DrawWidgetBackground(gfxContext* aContext, nsIFrame* aFrame,
StyleAppearance aAppearance,
const nsRect& aRect,
const nsRect& aDirtyRect,
DrawOverflow) {
const nsRect& aDirtyRect, DrawOverflow) {
return NS_OK;
}

3
widget/headless/HeadlessThemeGTK.h
View File

@ -19,8 +19,7 @@ class HeadlessThemeGTK final : private nsNativeTheme, public nsITheme {
HeadlessThemeGTK() = default;
NS_IMETHOD DrawWidgetBackground(gfxContext* aContext, nsIFrame* aFrame,
StyleAppearance aAppearance,
const nsRect& aRect,
const nsRect& aDirtyRect,
const nsRect& aRect, const nsRect& aDirtyRect,
DrawOverflow) override;
[[nodiscard]] LayoutDeviceIntMargin GetWidgetBorder(

9
widget/windows/ToastNotification.cpp
View File

@ -88,11 +88,10 @@ ToastNotification::ShowAlertNotification(
}
// vibrate is unused for now
nsTArray<uint32_t> vibrate;
nsresult rv =
alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText,
aAlertTextClickable, aAlertCookie, aBidi, aLang, aData,
aPrincipal, aInPrivateBrowsing, aRequireInteraction,
false, vibrate);
nsresult rv = alert->Init(aAlertName, aImageUrl, aAlertTitle, aAlertText,
aAlertTextClickable, aAlertCookie, aBidi, aLang,
aData, aPrincipal, aInPrivateBrowsing,
aRequireInteraction, false, vibrate);
if (NS_WARN_IF(NS_FAILED(rv))) {
return rv;
}

2
widget/windows/nsLookAndFeel.cpp
View File

@ -108,7 +108,7 @@ void nsLookAndFeel::NativeInit() { EnsureInit(); }
/* virtual */
void nsLookAndFeel::RefreshImpl() {
nsXPLookAndFeel::RefreshImpl();
mInitialized = false; // Fetch system colors next time they're used.
mInitialized = false; // Fetch system colors next time they're used.
}
nsresult nsLookAndFeel::NativeGetColor(ColorID aID, ColorScheme,

3
widget/windows/nsNativeThemeWin.h
View File

@ -32,8 +32,7 @@ class nsNativeThemeWin : private nsNativeTheme, public nsITheme {
// The nsITheme interface.
NS_IMETHOD DrawWidgetBackground(gfxContext* aContext, nsIFrame* aFrame,
StyleAppearance aAppearance,
const nsRect& aRect,
const nsRect& aDirtyRect,
const nsRect& aRect, const nsRect& aDirtyRect,
DrawOverflow) override;
[[nodiscard]] LayoutDeviceIntMargin GetWidgetBorder(