Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-14 05:45:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Backed out changeset 000cb7431848 -- bad commit messaage

Browse Source
This commit is contained in:
David Mandelin 2011-01-11 11:42:29 -08:00
parent ce67065786
commit 25ae2aa4b3
3 changed files with 4 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/src/jit-test/tests/basic/bug624041-1.js
View File

@ -1,8 +0,0 @@
var count = 0;
var a = [0, 1];
for (var i in a) {
assertEq(++count <= 1, true);
a.shift();
}

11
js/src/jit-test/tests/basic/bug624041-2.js
View File

@ -1,11 +0,0 @@
var s = '';
var a = [, 0, 1];
for (var i in a) {
a.reverse();
s += i + ',';
}
// Index of the element with value '0'.
assertEq(s, '1,');

13
js/src/jsarray.cpp
View File

@ -1484,14 +1484,9 @@ array_reverse(JSContext *cx, uintN argc, Value *vp)
uint32 lo = 0, hi = len - 1;
for (; lo < hi; lo++, hi--) {
Value origlo = obj->getDenseArrayElement(lo);
Value orighi = obj->getDenseArrayElement(hi);
obj->setDenseArrayElement(lo, orighi);
if (orighi.isMagic(JS_ARRAY_HOLE))
js_SuppressDeletedProperty(cx, obj, INT_TO_JSID(lo));
obj->setDenseArrayElement(hi, origlo);
if (origlo.isMagic(JS_ARRAY_HOLE))
js_SuppressDeletedProperty(cx, obj, INT_TO_JSID(hi));
Value tmp = obj->getDenseArrayElement(lo);
obj->setDenseArrayElement(lo, obj->getDenseArrayElement(hi));
obj->setDenseArrayElement(hi, tmp);
}
/*
@ -2161,8 +2156,6 @@ array_shift(JSContext *cx, uintN argc, Value *vp)
memmove(elems, elems + 1, length * sizeof(jsval));
obj->setDenseArrayElement(length, MagicValue(JS_ARRAY_HOLE));
obj->setArrayLength(length);
if (!js_SuppressDeletedProperty(cx, obj, INT_TO_JSID(length)));
return JS_FALSE;
return JS_TRUE;
}