mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-11 20:35:50 +00:00
Bug 941083 - invalidate widget wrappers on createWidget calls, r=mconley
--HG-- extra : rebase_source : 60a2c6eb754d6c9c87fb5987fe5fbd39be2581a5
This commit is contained in:
parent
917d2bfc6a
commit
26ee723822
@ -1506,6 +1506,16 @@ let CustomizableUIInternal = {
|
||||
}
|
||||
|
||||
gPalette.set(widget.id, widget);
|
||||
|
||||
// Clear our caches:
|
||||
gGroupWrapperCache.delete(widget.id);
|
||||
for (let [win, ] of gBuildWindows) {
|
||||
let cache = gSingleWrapperCache.get(win);
|
||||
if (cache) {
|
||||
cache.delete(widget.id);
|
||||
}
|
||||
}
|
||||
|
||||
this.notifyListeners("onWidgetCreated", widget.id);
|
||||
|
||||
if (widget.defaultArea) {
|
||||
|
@ -36,4 +36,5 @@ skip-if = true
|
||||
skip-if = os == "mac"
|
||||
|
||||
[browser_938980_navbar_collapsed.js]
|
||||
[browser_941083_invalidate_wrapper_cache_createWidget.js]
|
||||
[browser_panel_toggle.js]
|
||||
|
@ -0,0 +1,38 @@
|
||||
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
||||
|
||||
// See https://bugzilla.mozilla.org/show_bug.cgi?id=941083
|
||||
|
||||
const kWidgetId = "test-invalidate-wrapper-cache";
|
||||
|
||||
let gTests = [
|
||||
{
|
||||
desc: "Check createWidget invalidates the widget cache",
|
||||
run: function() {
|
||||
let groupWrapper = CustomizableUI.getWidget(kWidgetId);
|
||||
ok(groupWrapper, "Should get group wrapper.");
|
||||
let singleWrapper = groupWrapper.forWindow(window);
|
||||
ok(singleWrapper, "Should get single wrapper.");
|
||||
|
||||
CustomizableUI.createWidget({id: kWidgetId, label: "Test invalidating widgets caching"});
|
||||
|
||||
let newGroupWrapper = CustomizableUI.getWidget(kWidgetId);
|
||||
ok(newGroupWrapper, "Should get a group wrapper again.");
|
||||
isnot(newGroupWrapper, groupWrapper, "Wrappers shouldn't be the same.");
|
||||
isnot(newGroupWrapper.provider, groupWrapper.provider, "Wrapper providers shouldn't be the same.");
|
||||
|
||||
let newSingleWrapper = newGroupWrapper.forWindow(window);
|
||||
isnot(newSingleWrapper, singleWrapper, "Single wrappers shouldn't be the same.");
|
||||
isnot(newSingleWrapper.provider, singleWrapper.provider, "Single wrapper providers shouldn't be the same.");
|
||||
|
||||
CustomizableUI.destroyWidget(kWidgetId);
|
||||
ok(!CustomizableUI.getWidget(kWidgetId), "Shouldn't get a wrapper after destroying the widget.");
|
||||
},
|
||||
},
|
||||
];
|
||||
|
||||
function test() {
|
||||
waitForExplicitFinish();
|
||||
runTests(gTests);
|
||||
}
|
Loading…
Reference in New Issue
Block a user