Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 04:41:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1829006 - Remove unnecessary restriction about opaque scrollable windows. r=dholbert

Browse Source 
This comment doesn't make sense any more:

 * Scrollers don't use native anything.
 * Extensions can't openDialog themselves anymore.

This would allow user CSS to e.g. make PiP windows transparent. An
alternative would be to use scrolling="false" on the PiP window, but
since the restriction doesn't really seem necessary seems worth
removing.

Differential Revision: https://phabricator.services.mozilla.com/D175952
This commit is contained in:
Emilio Cobos Álvarez 2024-10-09 23:13:49 +00:00
parent caf33ecc17
commit 280ba92800
1 changed files with 7 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
layout/base/PresShell.cpp
View File

@ -11825,28 +11825,14 @@ void PresShell::SyncWindowProperties(bool aSync) {
return;
}
// Apply color scheme to the top level window widget.
windowWidget->SetColorScheme(
Some(LookAndFeel::ColorSchemeForFrame(rootFrame)));
AutoWeakFrame weak(rootFrame);
if (!GetRootScrollContainerFrame()) {
// Scrollframes use native widgets which don't work well with
// translucent windows, at least in Windows XP. So if the document
// has a root scrollrame it's useless to try to make it transparent,
// we'll just get something broken.
// We can change this to allow translucent toplevel HTML documents
// (e.g. to do something like Dashboard widgets), once we
// have broad support for translucent scrolled documents, but be
// careful because apparently some Firefox extensions expect
// openDialog("something.html") to produce an opaque window
// even if the HTML doesn't have a background-color set.
auto* canvas = GetCanvasFrame();
widget::TransparencyMode mode = nsLayoutUtils::GetFrameTransparency(
canvas ? canvas : rootFrame, rootFrame);
windowWidget->SetTransparencyMode(mode);
// For macOS, apply color scheme to the top level window widget.
windowWidget->SetColorScheme(
Some(LookAndFeel::ColorSchemeForFrame(rootFrame)));
}
auto* canvas = GetCanvasFrame();
windowWidget->SetTransparencyMode(nsLayoutUtils::GetFrameTransparency(
canvas ? canvas : rootFrame, rootFrame));
if (!weak.IsAlive()) {
return;
}