Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-09 00:11:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 469720 - tabindex of -1 set in javascript ignored on file input, r+sr=bz

Browse Source
This commit is contained in:
Olli Pettay 2008-12-17 09:33:33 +02:00
parent e9e4d416ee
commit 28cb4846da
2 changed files with 85 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

82
content/events/test/test_bug238987.html
View File

@ -117,23 +117,23 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=238987
utils.sendKeyEvent("keyup", key, 0, modifier);
if (shouldStop) {
// Did focus handling succeed
ok(forwardFocusArray.length == 0,
is(forwardFocusArray.length, 0,
"Not all forward tabbing focus tests were run, " +
forwardFocusArray.toString());
ok(backwardFocusArray.length == 0,
is(backwardFocusArray.length, 0,
"Not all backward tabbing focus tests were run, " +
backwardFocusArray.toString());
ok(expectedWindowFocusCount == 0,
is(expectedWindowFocusCount, 0,
"|window| didn't get the right amount of focus events");
// and blur.
ok(forwardBlurArray.length == 0,
is(forwardBlurArray.length, 0,
"Not all forward tabbing blur tests were run, " +
forwardBlurArray.toString());
ok(backwardBlurArray.length == 0,
is(backwardBlurArray.length, 0,
"Not all backward tabbing blur tests were run, " +
backwardBlurArray.toString());
ok(expectedWindowBlurCount == 0,
is(expectedWindowBlurCount, 0,
"|window| didn't get the right amount of blur events");
setOrRestoreTabFocus(0);
SimpleTest.finish();
@ -154,6 +154,9 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=238987
elements[i].addEventListener("focus", handleFocus, false);
elements[i].addEventListener("blur", handleBlur, false);
}
if (elements[i].getAttribute("tabindex") == "1") {
elements[i].setAttribute("tabindex", "-1");
}
}
tab();
}
@ -206,6 +209,73 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=238987
<tr>
<td>tabindex="0"</td><td><span tabindex="0" id="i12">span</span></td>
</tr>
<tr>
<td><h3>Form elements with tabindex="-1"</h3></td>
</tr>
<tr>
<td>type="text"</td><td><input type="text" tabindex="-1" value=""></td>
</tr>
<tr>
<td>type="button"</td><td><input type="button" tabindex="-1" value="type='button'"></td>
</tr>
<tr>
<td>type="checkbox"</td><td><input type="checkbox" tabindex="-1"></td>
</tr>
<tr>
<td>type="radio" checked</td><td><input type="radio" tabindex="-1" name="radio3" checked>
<input type="radio" tabindex="-1" name="radio3"></td>
</tr>
<tr>
<td>type="radio"</td><td><input type="radio" tabindex="-1" name="radio4">
<input type="radio" tabindex="-1" name="radio4"></td>
</tr>
<tr>
<td>type="password"</td><td><input type="password" tabindex="-1"></td>
</tr>
<tr>
<td>type="file"</td><td><input type="file" tabindex="-1"></td>
</tr>
<tr>
<td>button</td><td><button tabindex="-1">button</button></td>
</tr>
<tr>
<td>select</td><td><select tabindex="-1"><option>select</option></select></td>
</tr>
<tr>
<td><h3>Form elements with .setAttribute("tabindex", "-1")</h3></td>
</tr>
<tr>
<td>type="text"</td><td><input type="text" tabindex="1" value=""></td>
</tr>
<tr>
<td>type="button"</td><td><input type="button" tabindex="1" value="type='button'"></td>
</tr>
<tr>
<td>type="checkbox"</td><td><input type="checkbox" tabindex="1"></td>
</tr>
<tr>
<td>type="radio" checked</td><td><input type="radio" tabindex="1" name="radio5" checked>
<input type="radio" tabindex="1" name="radio5"></td>
</tr>
<tr>
<td>type="radio"</td><td><input type="radio" tabindex="1" name="radio6">
<input type="radio" tabindex="1" name="radio6"></td>
</tr>
<tr>
<td>type="password"</td><td><input type="password" tabindex="1"></td>
</tr>
<tr>
<td>type="file"</td><td><input type="file" tabindex="1"></td>
</tr>
<tr>
<td>button</td><td><button tabindex="1">button</button></td>
</tr>
<tr>
<td>select</td><td><select tabindex="1"><option>select</option></select></td>
</tr>
</tbody>
</table>
<h4 tabindex="0" id="end">done.</h4>

16
layout/forms/nsFileControlFrame.cpp
View File

@ -503,13 +503,15 @@ nsFileControlFrame::AttributeChanged(PRInt32 aNameSpaceID,
PRInt32 aModType)
{
// propagate disabled to text / button inputs
if (aNameSpaceID == kNameSpaceID_None &&
aAttribute == nsGkAtoms::disabled) {
SyncAttr(aNameSpaceID, aAttribute, SYNC_BOTH);
// propagate size to text
} else if (aNameSpaceID == kNameSpaceID_None &&
aAttribute == nsGkAtoms::size) {
SyncAttr(aNameSpaceID, aAttribute, SYNC_TEXT);
if (aNameSpaceID == kNameSpaceID_None) {
if (aAttribute == nsGkAtoms::disabled) {
SyncAttr(aNameSpaceID, aAttribute, SYNC_BOTH);
// propagate size to text
} else if (aAttribute == nsGkAtoms::size) {
SyncAttr(aNameSpaceID, aAttribute, SYNC_TEXT);
} else if (aAttribute == nsGkAtoms::tabindex) {
SyncAttr(aNameSpaceID, aAttribute, SYNC_BUTTON);
}
}
return nsAreaFrame::AttributeChanged(aNameSpaceID, aAttribute, aModType);