Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-27 04:38:02 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1687267 - remove pending history navigations when swithing to another process, r=peterv

Browse Source 
The patch is based on code inspection. Crashes seem to happen when mHistory has been cleared,
and yet PendingAsyncHistoryNavigation::Run calls Go().

Differential Revision: https://phabricator.services.mozilla.com/D102874
This commit is contained in:
Olli Pettay 2021-01-25 13:35:23 +00:00
parent 979ff1ff5d
commit 28d6ee58c1
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docshell/shistory/ChildSHistory.cpp
View File

@ -30,7 +30,11 @@ void ChildSHistory::SetBrowsingContext(BrowsingContext* aBrowsingContext) {
void ChildSHistory::SetIsInProcess(bool aIsInProcess) {
if (!aIsInProcess) {
mHistory = nullptr;
MOZ_ASSERT_IF(mozilla::SessionHistoryInParent(), !mHistory);
if (!mozilla::SessionHistoryInParent()) {
RemovePendingHistoryNavigations();
mHistory = nullptr;
}
return;
}