Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-07 09:54:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Backout change fb3c323635d6 (bug 1347400) because the telemetry probe didn't prove to be useful

Browse Source
This commit is contained in:
Ehsan Akhgari 2017-04-15 17:19:13 -04:00
parent 96f0bd0fb6
commit 29071e6146
2 changed files with 1 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
image/imgLoader.cpp
View File

@ -15,7 +15,6 @@
#include "mozilla/Move.h"
#include "mozilla/Preferences.h"
#include "mozilla/ChaosMode.h"
#include "mozilla/Telemetry.h"
#include "nsImageModule.h"
#include "imgRequestProxy.h"
@ -2090,12 +2089,6 @@ imgLoader::LoadImage(nsIURI* aURI,
const nsAString& initiatorType,
imgRequestProxy** _retval)
{
// Note: We round the time to the nearest milliseconds. Due to this rounding,
// the actual minimum value is 500 microseconds.
static const uint32_t kMinTelemetryLatencyMs = 1;
mozilla::TimeStamp start = TimeStamp::Now();
VerifyCacheSizes();
NS_ASSERTION(aURI, "imgLoader::LoadImage -- NULL URI pointer");
@ -2343,11 +2336,8 @@ imgLoader::LoadImage(nsIURI* aURI,
if (!newChannel) {
proxy->NotifyListener();
}
}
uint32_t latencyMs = round((TimeStamp::Now() - start).ToMilliseconds());
if (XRE_IsContentProcess() && latencyMs >= kMinTelemetryLatencyMs) {
Telemetry::Accumulate(Telemetry::IMAGE_LOAD_TRIGGER_LATENCY_MS, latencyMs);
return rv;
}
NS_ASSERTION(*_retval, "imgLoader::LoadImage -- no return value");

10
toolkit/components/telemetry/Histograms.json
View File

@ -1608,16 +1608,6 @@
"n_buckets": 50,
"description": "GIF image decode speed (Kbytes/sec)"
},
"IMAGE_LOAD_TRIGGER_LATENCY_MS": {
"alert_emails": ["ehsan@mozilla.com", "gfx-telemetry-alerts@mozilla.com"],
"expires_in_version": "60",
"bug_numbers": [1347376],
"kind": "exponential",
"low": 1,
"high": 1000,
"n_buckets": 50,
"description": "Measures the number of milliseconds we spend inside imgLoader::LoadImage(). Note: only calls that take more than 500 microseconds and happen in the content process are included in this probe."
},
"IMAGE_DECODE_SPEED_PNG": {
"alert_emails": ["gfx-telemetry-alerts@mozilla.com"],
"expires_in_version": "never",