Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-01 00:32:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1820123 [wpt PR 38804] - Disallow breaks before trailing border/padding in table cells., a=testonly

Browse Source 
Automatic update from web-platform-tests
Disallow breaks before trailing border/padding in table cells.

We normally allow a last-resort break between the content box block-end
and any block-end border/padding, if that can help avoid fragmentainer
overflow. Don't do this for table cells, as that upsets the row
stretching machinery. See how PlaceCells() is rerun in
NGTableRowLayoutAlgorithm::Layout() with a new row size.

This is a simple fix. A more elaborate fix would be to store a flag in
the break token, saying that we're past the content box (we already have
one for being past the *border* box), and just keep on allowing such
breaks before trailing border/padding. But it just doesn't seem worth it
at this point.

Bug: 1420637
Change-Id: Ie43f3af898bab5cbf9a062232383adf307376ced
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4303193
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1113046}

--

wpt-commits: d031b37d079e789288f76164cd44b8c556d79d68
wpt-pr: 38804
This commit is contained in:
Morten Stenshorne 2023-03-06 14:04:33 +00:00 committed by moz-wptsync-bot
parent 09e2df4126
commit 299a9dd643
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
testing/web-platform/tests/css/css-break/table/cell-large-bottom-padding-crash.html Normal file
View File

@ -0,0 +1,6 @@
<!DOCTYPE html>
<link rel="author" title="Morten Stenshorne" href="mailto:mstensho@chromium.org">
<link rel="help" href="https://bugs.chromium.org/p/chromium/issues/detail?id=1420637">
<div style="columns:2; height:100px; column-fill:auto;">
<div style="display:table-cell; padding-bottom:400px;">boo</div>
</div>