Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-21 01:05:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1635196 - Make sure GetSymbolTableMozPromise promise is always fulfilled - r=mstange

Browse Source 
In rare cases, a dispatch may fail (e.g., threads are shutting down), we should handle this failure by rejecting the promise on the spot.

Depends on D73791

Differential Revision: https://phabricator.services.mozilla.com/D73792
This commit is contained in:
Gerald Squelart 2020-05-05 21:06:15 +00:00
parent 32a725405b
commit 29ec866e31
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/profiler/gecko/nsProfiler.cpp
View File

@ -870,7 +870,7 @@ RefPtr<nsProfiler::SymbolTablePromise> nsProfiler::GetSymbolTableMozPromise(
}
}
mSymbolTableThread->Dispatch(NS_NewRunnableFunction(
nsresult rv = mSymbolTableThread->Dispatch(NS_NewRunnableFunction(
"nsProfiler::GetSymbolTableMozPromise runnable on ProfSymbolTable thread",
[promiseHolder = std::move(promiseHolder),
debugPath = nsCString(aDebugPath),
@ -887,6 +887,12 @@ RefPtr<nsProfiler::SymbolTablePromise> nsProfiler::GetSymbolTableMozPromise(
}
}));
if (NS_WARN_IF(NS_FAILED(rv))) {
// Get-symbol task was not dispatched and therefore won't fulfill the
// promise, we must reject the promise now.
promiseHolder.Reject(NS_ERROR_FAILURE, __func__);
}
return promise;
}