Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 16:25:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1616066 - Remove type checks for str/bool in BrowsertimeResultsHandler. r=perftest-reviewers,octavian_negru

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D63456

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Marian Raiciof 2020-02-20 14:22:22 +00:00
parent ae9503e243
commit 2a17b95cb1
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
testing/raptor/raptor/results.py
View File

@ -9,7 +9,6 @@ from __future__ import absolute_import
import json
import os
from distutils.util import strtobool
from abc import ABCMeta, abstractmethod
from logger.logger import RaptorLogger
from output import RaptorOutput, BrowsertimeOutput
@ -616,10 +615,8 @@ class BrowsertimeResultsHandler(PerftestResultsHandler):
# Try to get subtest values or use the defaults
# If values not available use the defaults
subtest_lower_is_better = test.get("subtest_lower_is_better", "True")
new_result["subtest_lower_is_better"] = bool(
strtobool(subtest_lower_is_better)
) if isinstance(subtest_lower_is_better, str) else subtest_lower_is_better
subtest_lower_is_better = test.get("subtest_lower_is_better", True)
new_result["subtest_lower_is_better"] = subtest_lower_is_better
new_result["subtest_unit"] = test.get("subtest_unit", "ms")
LOG.info("parsed new result: %s" % str(new_result))