Don't return NS_OK in failure cases. Instead, return a well-known value that nsGlobalWindow can convert. bug 382196, r+sr=jst

This commit is contained in:
mrbkap@gmail.com 2007-06-15 14:47:37 -07:00
parent 7945ecd6e2
commit 2a674b1444

View File

@ -238,7 +238,8 @@ nsJSScriptTimeoutHandler::Init(nsIScriptContext *aContext, PRBool aIsInterval,
::JS_ReportError(cx, "Function %s requires at least 1 parameter",
aIsInterval ? kSetIntervalStr : kSetTimeoutStr);
return ncc->SetExceptionWasThrown(PR_TRUE);
ncc->SetExceptionWasThrown(PR_TRUE);
return NS_ERROR_DOM_TYPE_ERR;
}
if (argc > 1 && !::JS_ValueToECMAInt32(cx, argv[1], &interval)) {
@ -246,7 +247,8 @@ nsJSScriptTimeoutHandler::Init(nsIScriptContext *aContext, PRBool aIsInterval,
"Second argument to %s must be a millisecond interval",
aIsInterval ? kSetIntervalStr : kSetTimeoutStr);
return ncc->SetExceptionWasThrown(PR_TRUE);
ncc->SetExceptionWasThrown(PR_TRUE);
return NS_ERROR_DOM_TYPE_ERR;
}
switch (::JS_TypeOfValue(cx, argv[0])) {