Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-04 21:18:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1620163 Fix perfdocs to not skip missing tests r=sparky,perftest-reviewers

Browse Source 
There is a logic error in the code that is not catching missing tests. Also, the manifest path for each test needs to be added along with the test name so the logger can be able to print it.

Differential Revision: https://phabricator.services.mozilla.com/D65473

--HG--
extra : moz-landing-system : lando
This commit is contained in:
alexandru.ionescu 2020-03-05 13:13:00 +00:00
parent cb8a401831
commit 2ac76df563
2 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/lint/perfdocs/framework_gatherers.py
View File

@ -116,7 +116,7 @@ class RaptorGatherer(FrameworkGatherer):
'''
test_manifest = TestManifest([manifest_path], strict=False)
test_list = test_manifest.active_tests(exists=False, disabled=False)
subtest_list = [subtest["name"] for subtest in test_list]
subtest_list = {subtest["name"]: subtest["manifest"] for subtest in test_list}
return subtest_list
@ -140,11 +140,9 @@ class RaptorGatherer(FrameworkGatherer):
# and place the subtests into self._test_list under the same key
for suite_name, manifest_paths in suite_list.items():
if not self._test_list.get(suite_name):
self._test_list[suite_name] = []
self._test_list[suite_name] = {}
for i, manifest_path in enumerate(manifest_paths, 1):
subtest_list = self._get_subtests_from_ini(manifest_path)
self._test_list[suite_name].extend(subtest_list)
if i == len(manifest_paths):
self._test_list[suite_name] = sorted(self._test_list[suite_name])
self._test_list[suite_name].update(subtest_list)
return self._test_list

28
tools/lint/perfdocs/verifier.py
View File

@ -117,25 +117,25 @@ class Verifier(object):
# Suite found - now check if any tests in YAML
# definitions doesn't exist
ytests = ytests['tests']
for suite_name in ytests:
for test_name in ytests:
foundtest = False
for t in framework_info["test_list"][suite]:
tb = os.path.basename(t)
tb = re.sub("\..*", "", tb)
if suite_name == tb:
# Found an exact match for the suite_name
if test_name == tb:
# Found an exact match for the test_name
foundtest = True
break
if suite_name in tb:
# Found a 'fuzzy' match for the suite_name
if test_name in tb:
# Found a 'fuzzy' match for the test_name
# i.e. 'wasm' could exist for all raptor wasm tests
global_descriptions[suite].append(suite_name)
global_descriptions[suite].append(test_name)
foundtest = True
break
if not foundtest:
logger.warning(
"Could not find an existing test for {} - bad test name?".format(
suite_name
test_name
),
framework_info["yml_path"]
)
@ -165,15 +165,15 @@ class Verifier(object):
tests_found = 0
missing_tests = []
test_to_manifest = {}
for test_name in test_list:
tb = os.path.basename(test_name)
for test_name, manifest_path in test_list.items():
tb = os.path.basename(manifest_path)
tb = re.sub("\..*", "", tb)
if stests.get(tb) or stests.get(test_name):
# Test description exists, continue with the next test
tests_found += 1
continue
test_to_manifest[tb] = test_name
missing_tests.append(tb)
test_to_manifest[test_name] = manifest_path
missing_tests.append(test_name)
# Check if global test descriptions exist (i.e.
# ones that cover all of tp6) for the missing tests
@ -181,8 +181,11 @@ class Verifier(object):
for mt in missing_tests:
found = False
for test_name in global_descriptions[suite]:
# Global test exists for this missing test
if mt.startswith(test_name):
found = True
break
if test_name in mt:
# Global test exists for this missing test
found = True
break
if not found:
@ -196,7 +199,6 @@ class Verifier(object):
"Could not find a test description for {}".format(test_name),
test_to_manifest[test_name]
)
continue
def validate_yaml(self, yaml_path):
'''