Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 15:52:07 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1638925 - Ensure that the event gets destroyed within the guards r=jya

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D80171
This commit is contained in:
Honza Bambas 2020-06-24 13:51:25 +00:00
parent 2946f7e5b9
commit 2b6b893f89
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
xpcom/threads/TaskQueue.cpp
View File

@ -144,26 +144,26 @@ nsresult TaskQueue::Runner::Run() {
}
MOZ_ASSERT(event.event);
// Note that dropping the queue monitor before running the task, and
// taking the monitor again after the task has run ensures we have memory
// fences enforced. This means that if the object we're calling wasn't
// designed to be threadsafe, it will be, provided we're only calling it
// in this task queue.
{
LogRunnable::Run log(event.event);
// Note that dropping the queue monitor before running the task, and
// taking the monitor again after the task has run ensures we have memory
// fences enforced. This means that if the object we're calling wasn't
// designed to be threadsafe, it will be, provided we're only calling it
// in this task queue.
AutoTaskGuard g(mQueue);
SerialEventTargetGuard tg(mQueue);
{
AutoTaskGuard g(mQueue);
SerialEventTargetGuard tg(mQueue);
event.event->Run();
}
LogRunnable::Run log(event.event);
// Drop the reference to event. The event will hold a reference to the
// object it's calling, and we don't want to keep it alive, it may be
// making assumptions what holds references to it. This is especially
// the case if the object is waiting for us to shutdown, so that it
// can shutdown (like in the MediaDecoderStateMachine's SHUTDOWN case).
event.event = nullptr;
event.event->Run();
// Drop the reference to event. The event will hold a reference to the
// object it's calling, and we don't want to keep it alive, it may be
// making assumptions what holds references to it. This is especially
// the case if the object is waiting for us to shutdown, so that it
// can shutdown (like in the MediaDecoderStateMachine's SHUTDOWN case).
event.event = nullptr;
}
}
{