Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 03:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1425577 - Do not clone the state for each message of a batch; r=bgrins.

Browse Source 
Here, in the case of a MESSAGES_ADD action, we clone the state before
calling addMessage. Then, in addMessage, we can mutate the cloned state.
This saves a lot of time since we don't have to re-create a new state
for each message.

MozReview-Commit-ID: GDBFBytKp5u

--HG--
extra : rebase_source : bfa8252b3dc2e191fa83cd2ad8cb60ab8bb77366
This commit is contained in:
Nicolas Chevobbe 2018-01-24 11:21:40 +01:00
parent ded973c413
commit 2b915e93ba
1 changed files with 31 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
devtools/client/webconsole/new-console-output/reducers/messages.js
View File

@ -56,16 +56,27 @@ const MessageState = overrides => Object.freeze(Object.assign({
networkMessagesUpdateById: {},
}, overrides));
function cloneState(state) {
return {
messagesById: new Map(state.messagesById),
visibleMessages: [...state.visibleMessages],
filteredMessagesCount: {...state.filteredMessagesCount},
messagesUiById: [...state.messagesUiById],
messagesTableDataById: new Map(state.messagesTableDataById),
groupsById: new Map(state.groupsById),
currentGroup: state.currentGroup,
removedActors: [...state.removedActors],
repeatById: {...state.repeatById},
networkMessagesUpdateById: {...state.networkMessagesUpdateById},
};
}
function addMessage(state, filtersState, prefsState, newMessage) {
const {
messagesById,
messagesUiById,
groupsById,
currentGroup,
repeatById,
visibleMessages,
filteredMessagesCount,
networkMessagesUpdateById,
} = state;
if (newMessage.type === constants.MESSAGE_TYPE.NULL_MESSAGE) {
@ -75,10 +86,8 @@ function addMessage(state, filtersState, prefsState, newMessage) {
if (newMessage.type === constants.MESSAGE_TYPE.END_GROUP) {
// Compute the new current group.
return {
...state,
currentGroup: getNewCurrentGroup(currentGroup, groupsById)
};
state.currentGroup = getNewCurrentGroup(currentGroup, groupsById);
return state;
}
if (newMessage.allowRepeating && messagesById.size > 0) {
@ -88,64 +97,51 @@ function addMessage(state, filtersState, prefsState, newMessage) {
lastMessage.repeatId === newMessage.repeatId
&& lastMessage.groupId === currentGroup
) {
return {
...state,
repeatById: {
...repeatById,
[lastMessage.id]: (repeatById[lastMessage.id] || 1) + 1
}
};
state.repeatById[lastMessage.id] = (repeatById[lastMessage.id] || 1) + 1;
return state;
}
}
let newState = {...state};
// Add the new message with a reference to the parent group.
let parentGroups = getParentGroups(currentGroup, groupsById);
newMessage.groupId = currentGroup;
newMessage.indent = parentGroups.length;
const addedMessage = Object.freeze(newMessage);
newState.messagesById = (new Map(newState.messagesById))
.set(newMessage.id, addedMessage);
state.messagesById.set(newMessage.id, addedMessage);
if (newMessage.type === "trace") {
// We want the stacktrace to be open by default.
newState.messagesUiById = [...messagesUiById, newMessage.id];
state.messagesUiById.push(newMessage.id);
} else if (isGroupType(newMessage.type)) {
newState.currentGroup = newMessage.id;
newState.groupsById = (new Map(newState.groupsById))
.set(newMessage.id, parentGroups);
state.currentGroup = newMessage.id;
state.groupsById.set(newMessage.id, parentGroups);
if (newMessage.type === constants.MESSAGE_TYPE.START_GROUP) {
// We want the group to be open by default.
newState.messagesUiById = [...messagesUiById, newMessage.id];
state.messagesUiById.push(newMessage.id);
}
}
const {
visible,
cause
} = getMessageVisibility(addedMessage, newState, filtersState);
} = getMessageVisibility(addedMessage, state, filtersState);
if (visible) {
newState.visibleMessages = [...visibleMessages, newMessage.id];
state.visibleMessages.push(newMessage.id);
} else if (DEFAULT_FILTERS.includes(cause)) {
newState.filteredMessagesCount = {
...filteredMessagesCount,
global: filteredMessagesCount.global + 1,
[cause]: filteredMessagesCount[cause] + 1
};
state.filteredMessagesCount.global++;
state.filteredMessagesCount[cause]++;
}
// Append received network-data also into networkMessagesUpdateById
// that is responsible for collecting (lazy loaded) HTTP payload data.
if (newMessage.source == "network") {
newState.networkMessagesUpdateById = Object.assign({}, networkMessagesUpdateById, {
[newMessage.actor]: newMessage
});
state.networkMessagesUpdateById[newMessage.actor] = newMessage;
}
return newState;
return state;
}
function messages(state = MessageState(), action, filtersState, prefsState) {
@ -163,8 +159,6 @@ function messages(state = MessageState(), action, filtersState, prefsState) {
let newState;
switch (action.type) {
case constants.MESSAGES_ADD:
newState = state;
// Preemptively remove messages that will never be rendered
let list = [];
let prunableCount = 0;
@ -191,6 +185,7 @@ function messages(state = MessageState(), action, filtersState, prefsState) {
lastMessageRepeatId = message.repeatId;
}
newState = cloneState(state);
list.forEach(message => {
newState = addMessage(newState, filtersState, prefsState, message);
});